Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.29] use preview endpoint instead of thumbnail #13453

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 23, 2024

Backport of PR #13164

do not use path, but fileid for previews

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@backportbot backportbot bot added this to the Nextcloud App 3.29.2 RC1 milestone Aug 23, 2024
Copy link

Lint

Typestable-3.29PR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness7171
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1919
Total566566

@alperozturk96 alperozturk96 modified the milestones: Nextcloud App 3.29.2 RC1, Nextcloud App 3.29.3 Aug 23, 2024
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

Lint

Typestable-3.29PR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness7171
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1919
Total566566

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13453.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (c331add) to head (30229b3).
Report is 7 commits behind head on stable-3.29.

Files Patch % Lines
...loud/android/datamodel/ThumbnailsCacheManager.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             stable-3.29   #13453       +/-   ##
==================================================
+ Coverage               0   27.21%   +27.21%     
- Complexity             0     3319     +3319     
==================================================
  Files                  0      635      +635     
  Lines                  0    46821    +46821     
  Branches               0     6207     +6207     
==================================================
+ Hits                   0    12742    +12742     
- Misses                 0    32194    +32194     
- Partials               0     1885     +1885     
Files Coverage Δ
...loud/android/datamodel/ThumbnailsCacheManager.java 35.42% <50.00%> (ø)

... and 634 files with indirect coverage changes

@alperozturk96 alperozturk96 merged commit 909180b into stable-3.29 Aug 23, 2024
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/13164/stable-3.29 branch October 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants