-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MimeTypes #4434
Update MimeTypes #4434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4434 +/- ##
=========================================
Coverage ? 17.03%
Complexity ? 3
=========================================
Files ? 363
Lines ? 32043
Branches ? 4511
=========================================
Hits ? 5457
Misses ? 25695
Partials ? 891
|
5877cf8
to
4a7d61f
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…for .love files Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…for .m files Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
4a7d61f
to
2f30227
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@tobiasKaminsky I did some refactoring/extension of thhe mime type detection to not just rely on the OS but also use the ever exisitng local mime type maps as a fallback :) |
@tobiasKaminsky I shared a folder with you with plain/empty files with all the extensions added via this PR :) |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10793.apk |
Codacy271Lint
SpotBugs (new)
SpotBugs (master)
|
/backport to stable-3.8 |
backport to stable-3.8 in #4456 |
Updated MimeType list to Nc17 list, also implemented 2 minor extensions to support opened issues.
I vote for simply merging the change (if the code itself is fine and works) and if as discussed we want to move to a mime type mapping fetched from the server than we should do that in a later, separate PR.