Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MimeTypes #4434

Merged
merged 4 commits into from
Sep 4, 2019
Merged

Update MimeTypes #4434

merged 4 commits into from
Sep 4, 2019

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Aug 28, 2019

Updated MimeType list to Nc17 list, also implemented 2 minor extensions to support opened issues.

I vote for simply merging the change (if the code itself is fine and works) and if as discussed we want to move to a mime type mapping fetched from the server than we should do that in a later, separate PR.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c6f6ce8). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4434   +/-   ##
=========================================
  Coverage          ?   17.03%           
  Complexity        ?        3           
=========================================
  Files             ?      363           
  Lines             ?    32043           
  Branches          ?     4511           
=========================================
  Hits              ?     5457           
  Misses            ?    25695           
  Partials          ?      891
Impacted Files Coverage Δ Complexity Δ
.../java/com/owncloud/android/utils/MimeTypeUtil.java 86.61% <100%> (ø) 0 <0> (?)

@AndyScherzinger AndyScherzinger force-pushed the mimetypes branch 2 times, most recently from 5877cf8 to 4a7d61f Compare September 2, 2019 13:37
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…for .love files

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…for .m files

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

@tobiasKaminsky I did some refactoring/extension of thhe mime type detection to not just rely on the OS but also use the ever exisitng local mime type maps as a fallback :)

@AndyScherzinger
Copy link
Member Author

@tobiasKaminsky I shared a folder with you with plain/empty files with all the extensions added via this PR :)

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10793.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

271

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings47
Dodgy code Warnings140
Total426

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings47
Dodgy code Warnings140
Total426

@tobiasKaminsky
Copy link
Member

/backport to stable-3.8

@tobiasKaminsky tobiasKaminsky merged commit 4c0e1c0 into master Sep 4, 2019
@tobiasKaminsky tobiasKaminsky deleted the mimetypes branch September 4, 2019 05:57
@backportbot-nextcloud
Copy link

backport to stable-3.8 in #4456

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.9.0 milestone Sep 4, 2019
tobiasKaminsky added a commit that referenced this pull request Sep 5, 2019
7bc162b Merge pull request #4458 from nextcloud/community
7fae762 rename participate -> community
e8d585e Remote wipe (#4455)
4c0e1c0 Update MimeTypes (#4434)
0b26aa7 Remote wipe
9168446 daily dev 20190904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matlab source files not opened as text files nextcloud doesn't know how to open .love files
3 participants