-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename participate -> community #4458
Conversation
@tobiasKaminsky doesn't the rename lead to the need that all strings need to be translated again? (shouldn't be too much work though) |
Yes, but we have plenty of time as it will be in 3.9 and for translators it should be just one click on each as the value did not changed and therefore transifex suggests the correct translation. I was thinking if I should change it, but I think it is better to have all in a common term. |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
47efb7c
to
7fae762
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10823.apk |
Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10823 |
Codacy275Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
@tobiasKaminsky spotbugs increased while not being increased?! |
Also fixed button on white screen
Signed-off-by: tobiasKaminsky tobias@kaminsky.me