Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename participate -> community #4458

Merged
merged 1 commit into from
Sep 4, 2019
Merged

rename participate -> community #4458

merged 1 commit into from
Sep 4, 2019

Conversation

tobiasKaminsky
Copy link
Member

2019-09-04-081310 2019-09-04-081406

Also fixed button on white screen

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@AndyScherzinger
Copy link
Member

@tobiasKaminsky doesn't the rename lead to the need that all strings need to be translated again? (shouldn't be too much work though)

@tobiasKaminsky
Copy link
Member Author

@tobiasKaminsky doesn't the rename lead to the need that all strings need to be translated again? (shouldn't be too much work though)

Yes, but we have plenty of time as it will be in 3.9 and for translators it should be just one click on each as the value did not changed and therefore transifex suggests the correct translation.

I was thinking if I should change it, but I think it is better to have all in a common term.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10823.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Codacy

275

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings141
Total429

SpotBugs increased!

@AndyScherzinger
Copy link
Member

@tobiasKaminsky spotbugs increased while not being increased?!

@AndyScherzinger AndyScherzinger merged commit 7bc162b into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the community branch September 4, 2019 18:07
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.9.0 milestone Sep 4, 2019
tobiasKaminsky added a commit that referenced this pull request Sep 5, 2019
7bc162b Merge pull request #4458 from nextcloud/community
7fae762 rename participate -> community
e8d585e Remote wipe (#4455)
4c0e1c0 Update MimeTypes (#4434)
0b26aa7 Remote wipe
9168446 daily dev 20190904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants