bump to latest SDK #4657

tobiasKaminsky · 2019-10-11T05:18:42Z

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

tobiasKaminsky · 2019-10-11T05:18:53Z

/backport to stable-3.8

AndyScherzinger · 2019-10-11T06:13:16Z

@tobiasKaminsky massive lint score increase likely due to changed rules because of the sdk bump

tobiasKaminsky · 2019-10-11T06:26:20Z

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:53: Field requires API level Q (current min is 14): android.provider.MediaStore.MediaColumns#BUCKET_ID

https://developer.android.com/reference/android/provider/MediaStore.MediaColumns.html#BUCKET_ID

This just seems to be wrong. We have this since ages…

codecov · 2019-10-15T15:17:39Z

Codecov Report

Merging #4657 into master will decrease coverage by 0.02%.
The diff coverage is 27.27%.

@@             Coverage Diff             @@
##             master   #4657      +/-   ##
===========================================
- Coverage     17.72%   17.7%   -0.03%     
  Complexity        3       3              
===========================================
  Files           384     385       +1     
  Lines         32650   32680      +30     
  Branches       4597    4594       -3     
===========================================
- Hits           5788    5785       -3     
- Misses        25938   25966      +28     
- Partials        924     929       +5

Impacted Files	Coverage Δ	Complexity Δ
.../com/owncloud/android/datamodel/MediaProvider.java	`26.53% <27.27%> (-0.53%)`	`0 <0> (ø)`
...va/com/owncloud/android/ui/SquareLinearLayout.java	`0% <0%> (-50%)`	`0% <0%> (ø)`
.../android/ui/activity/ThemedPreferenceActivity.java	`63.63% <0%> (-3.04%)`	`0% <0%> (ø)`
...m/owncloud/android/ui/activity/DrawerActivity.java	`43.16% <0%> (-2.38%)`	`0% <0%> (ø)`
...in/java/com/owncloud/android/utils/ThemeUtils.java	`49.41% <0%> (-2.16%)`	`0% <0%> (ø)`
...xtcloud/client/preferences/AppPreferencesImpl.java	`58.37% <0%> (-1.52%)`	`0% <0%> (ø)`
.../third_parties/daveKoeller/AlphanumComparator.java	`82.14% <0%> (-1.2%)`	`0% <0%> (ø)`
...ncloud/android/ui/fragment/OCFileListFragment.java	`25.58% <0%> (-0.28%)`	`0% <0%> (ø)`
src/main/java/com/owncloud/android/MainApp.java	`56.11% <0%> (-0.21%)`	`0% <0%> (ø)`
.../nextcloud/client/onboarding/WhatsNewActivity.java	`0% <0%> (ø)`	`0% <0%> (ø)`	⬇️
... and 26 more

AndyScherzinger · 2019-10-15T20:39:13Z

This just seems to be wrong. We have this since ages…

Yes and no ;) They have been in place for ages, now Google decided to move them up into the interface (via v29) and they are inherited from there, unfortunately this means that now you end up with lint warnings...

AndyScherzinger · 2019-10-16T07:46:13Z

@tobiasKaminsky Dies on Android Q Emulator. Take some pictures and then open the Auto Upload

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.nextcloud.client/com.owncloud.android.ui.activity.SyncedFoldersActivity}: java.lang.IllegalArgumentException: Invalid column Distinct bucket_id
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3270)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3409)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
     Caused by: java.lang.IllegalArgumentException: Invalid column Distinct bucket_id
        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:170)
        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:140)
        at android.content.ContentProviderProxy.query(ContentProviderNative.java:423)
        at android.content.ContentResolver.query(ContentResolver.java:944)
        at android.content.ContentResolver.query(ContentResolver.java:880)
        at android.content.ContentResolver.query(ContentResolver.java:836)
        at com.owncloud.android.datamodel.MediaProvider.getImageFolders(MediaProvider.java:81)
        at com.owncloud.android.ui.activity.SyncedFoldersActivity.load(SyncedFoldersActivity.java:249)
        at com.owncloud.android.ui.activity.SyncedFoldersActivity.setupContent(SyncedFoldersActivity.java:236)
        at com.owncloud.android.ui.activity.SyncedFoldersActivity.onCreate(SyncedFoldersActivity.java:162)
        at android.app.Activity.performCreate(Activity.java:7802)
        at android.app.Activity.performCreate(Activity.java:7791)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1299)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3245)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3409) 
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83) 
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016) 
        at android.os.Handler.dispatchMessage(Handler.java:107) 
        at android.os.Looper.loop(Looper.java:214) 
        at android.app.ActivityThread.main(ActivityThread.java:7356) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

tobiasKaminsky · 2019-10-18T10:04:50Z

Invalid column Distinct bucket_id

This is concatenated here:

android/src/main/java/com/owncloud/android/datamodel/MediaProvider.java

Lines 54 to 55 in 750bfbc

    
           private static final String[] IMAGES_FOLDER_PROJECTION = {"Distinct " + MediaStore.Images.Media.BUCKET_ID, 
        
                   MediaStore.Images.Media.BUCKET_DISPLAY_NAME};

I do not find a way how to do it better than to remove "distinct" and manually do a distinct…

AndyScherzinger · 2019-10-18T10:28:33Z

This is only happening due to the sdk bump, can distinct be set via api? If so can it be limited to the column?

Else I also have no idea how to do this properly except doing it like you said, manually afterwards.

tobiasKaminsky · 2019-12-03T08:46:56Z

I do the distinct part now manually.
Hopefully this will not take too much additionally time.

However, this is very rarely used and so it is acceptable to wait a bit longer.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky · 2019-12-03T08:49:40Z

After merging this, we can also merge the PR on library

tobiasKaminsky · 2019-12-03T10:38:03Z

Lint is only about: https://www.kaminsky.me/nc-dev/android-lint/11823.html#InlinedApi

tobiasKaminsky · 2019-12-03T11:42:56Z

This works also on Android 6.
Android 4/5 is failing due to other reasons for me at the moment…

tobiasKaminsky · 2019-12-09T10:50:17Z

Lint is only about: https://www.kaminsky.me/nc-dev/android-lint/11823.html#InlinedApi

@AndyScherzinger what do you think? Increase lint/spotbugs for this or try to get rid of it with annotations?

AndyScherzinger · 2019-12-09T10:53:07Z

what do you think? Increase lint/spotbugs for this or try to get rid of it with annotations?

I'd say so, yes 👍 It is documented and we can fix it over time but it shouldn't block development/merge :)

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

AndyScherzinger · 2019-12-09T11:11:49Z

@tobiasKaminsky you asked the backport bot for 3.8 while that should be 3.9 by now or none since I am unsure if you want to release this for 3.9.3+ or just 3.10+

nextcloud-android-bot · 2019-12-09T11:23:37Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11915.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

nextcloud-android-bot · 2019-12-09T11:34:03Z

Codacy

325

Lint

Type	master	PR
Warnings	59	73
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	104
Security Warnings	44
Dodgy code Warnings	136
Total	407

tobiasKaminsky · 2019-12-09T14:54:25Z

@tobiasKaminsky you asked the backport bot for 3.8 while that should be 3.9 by now or none since I am unsure if you want to release this for 3.9.3+ or just 3.10+

backport label was remove, so I hope that nothing gets backported, as we do not need it.
I hope there will be no 3.9.3, so 3.10 is fine :-)

AndyScherzinger · 2019-12-09T16:50:53Z

Just tested, works fine

5f6dc23 Merge pull request #4973 from nextcloud/addFastlane 1145c38 Merge pull request #4958 from Infomaniak/fix/see-detail-from-preview-nc fd3ff4c Merge pull request #4898 from siddharths2710/master 988e797 [tx-robot] updated from transifex 8062340 Merge pull request #4657 from nextcloud/bumpSDK 4b328cb manually increase spotbugs and lint 1290bbe Merge pull request #4918 from Infomaniak/fix/calendar-not-refreshed da104fc48 Merge pull request #4962 from Infomaniak/fix/add-activities-empty-icon 702c4f7 Merge pull request #4954 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.5.3 f7597c1 [tx-robot] updated from transifex c27f4ce [tx-robot] updated from transifex 7544257 [tx-robot] updated from transifex 4576d45 daily dev 20191207

tobiasKaminsky added the 3. to review label Oct 11, 2019

backportbot-nextcloud bot added the backport-request label Oct 11, 2019

tobiasKaminsky removed the backport-request label Oct 11, 2019

AndyScherzinger force-pushed the bumpSDK branch from 4e382df to 01b88ee Compare October 15, 2019 15:17

tobiasKaminsky mentioned this pull request Nov 29, 2019

Bump to sdk 29 nextcloud/android-library#362

Merged

1 task

tobiasKaminsky force-pushed the bumpSDK branch from 01b88ee to 05063f1 Compare December 3, 2019 08:45

tobiasKaminsky added 2 commits December 3, 2019 09:48

bump to latest SDK

92d872c

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

replaced distinct by manually unique via HashMap

3cf0e6e

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky force-pushed the bumpSDK branch from 05063f1 to 3cf0e6e Compare December 3, 2019 08:48

tobiasKaminsky requested a review from AndyScherzinger December 3, 2019 08:49

manually increase spotbugs and lint

4b328cb

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 9, 2019

AndyScherzinger approved these changes Dec 9, 2019

View reviewed changes

AndyScherzinger merged commit 8062340 into master Dec 9, 2019

delete-merged-branch bot deleted the bumpSDK branch December 9, 2019 16:51

backportbot-nextcloud bot added the backport-request label Dec 9, 2019

AndyScherzinger removed the backport-request label Dec 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump to latest SDK #4657

bump to latest SDK #4657

tobiasKaminsky commented Oct 11, 2019

tobiasKaminsky commented Oct 11, 2019

AndyScherzinger commented Oct 11, 2019

tobiasKaminsky commented Oct 11, 2019

codecov bot commented Oct 15, 2019 •

edited

Loading

AndyScherzinger commented Oct 15, 2019

AndyScherzinger commented Oct 16, 2019

tobiasKaminsky commented Oct 18, 2019

AndyScherzinger commented Oct 18, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

nextcloud-android-bot commented Dec 9, 2019

nextcloud-android-bot commented Dec 9, 2019

tobiasKaminsky commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

bump to latest SDK #4657

bump to latest SDK #4657

Conversation

tobiasKaminsky commented Oct 11, 2019

tobiasKaminsky commented Oct 11, 2019

AndyScherzinger commented Oct 11, 2019

tobiasKaminsky commented Oct 11, 2019

codecov bot commented Oct 15, 2019 • edited Loading

Codecov Report

AndyScherzinger commented Oct 15, 2019

AndyScherzinger commented Oct 16, 2019

tobiasKaminsky commented Oct 18, 2019

AndyScherzinger commented Oct 18, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 3, 2019

tobiasKaminsky commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

nextcloud-android-bot commented Dec 9, 2019

nextcloud-android-bot commented Dec 9, 2019

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

tobiasKaminsky commented Dec 9, 2019

AndyScherzinger commented Dec 9, 2019

codecov bot commented Oct 15, 2019 •

edited

Loading