Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug relative to activities empty icon #4962

Merged

Conversation

Kilian-Perisset
Copy link
Member

It fixes : #4960

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11893.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

325

Lint

TypemasterPR
Warnings5959
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings104
Security Warnings44
Dodgy code Warnings136
Total407

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4962 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4962      +/-   ##
============================================
+ Coverage     17.74%   17.75%   +<.01%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32665    32664       -1     
  Branches       4592     4592              
============================================
+ Hits           5797     5798       +1     
+ Misses        25941    25937       -4     
- Partials        927      929       +2
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/activities/ActivitiesActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.12% <0%> (-0.17%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 25.81% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/utils/ThemeUtils.java 50.97% <0%> (+1.55%) 0% <0%> (ø) ⬇️

@tobiasKaminsky tobiasKaminsky merged commit da104fc into nextcloud:master Dec 9, 2019
@tobiasKaminsky
Copy link
Member

Thank you 🎉

@Kilian-Perisset
Copy link
Member Author

Thanks <3, I close my branch & issue

@Kilian-Perisset Kilian-Perisset deleted the fix/add-activities-empty-icon branch December 9, 2019 10:54
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 9, 2019
tobiasKaminsky added a commit that referenced this pull request Dec 11, 2019
5f6dc23 Merge pull request #4973 from nextcloud/addFastlane
1145c38 Merge pull request #4958 from Infomaniak/fix/see-detail-from-preview-nc
fd3ff4c Merge pull request #4898 from siddharths2710/master
988e797 [tx-robot] updated from transifex
8062340 Merge pull request #4657 from nextcloud/bumpSDK
4b328cb manually increase spotbugs and lint
1290bbe Merge pull request #4918 from Infomaniak/fix/calendar-not-refreshed
da104fc48 Merge pull request #4962 from Infomaniak/fix/add-activities-empty-icon
702c4f7 Merge pull request #4954 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.5.3
f7597c1 [tx-robot] updated from transifex
c27f4ce [tx-robot] updated from transifex
7544257 [tx-robot] updated from transifex
4576d45 daily dev 20191207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No "Empty" icon when there are no activities
4 participants