Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: advanced deploy options #497

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: advanced deploy options #497

merged 1 commit into from
Jan 20, 2025

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Jan 17, 2025 •
edited
Loading

Related to: #406

Requires: nextcloud/server#50230

  1. Envs (during update removed envs - removed, present envs preserve previous values, new envs set with default values or empty)
  2. Mounts (bind host folders to ExApp container readwrite/readonly)

@bigcat88 bigcat88 requested a review from kyteinsky January 17, 2025 12:23
This was referenced Jan 17, 2025
Merged
Merged
@andrey18106 andrey18106 force-pushed the feat/advanced-deploy-options branch from 895ca0b to 69e0e1b Compare January 20, 2025 15:14
kyteinsky
kyteinsky requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works great!
see some minor issues.

lib/Command/ExApp/Register.php Outdated Show resolved Hide resolved
lib/Command/ExApp/Register.php Outdated Show resolved Hide resolved
lib/Service/ExAppDeployOptionsService.php Show resolved Hide resolved
lib/Command/ExApp/Register.php Show resolved Hide resolved
oleksandr-nc
oleksandr-nc approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally agree with Anupam's comments, and I'm giving my review in advance.

During backporting to the "stable31" branch CI will fail, so it is fine to merge with red CI to "stable31"

@andrey18106 andrey18106 force-pushed the feat/advanced-deploy-options branch from 69e0e1b to bd8b37f Compare January 20, 2025 17:21
@andrey18106
feat: Advanced deploy options
e27b687 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 force-pushed the feat/advanced-deploy-options branch from bd8b37f to e27b687 Compare January 20, 2025 17:23
@andrey18106 andrey18106 enabled auto-merge January 20, 2025 17:23
@andrey18106
Copy link
Collaborator Author

/backport to stable31

@andrey18106 andrey18106 disabled auto-merge January 20, 2025 20:21
@andrey18106 andrey18106 merged commit ad48bd8 into main Jan 20, 2025
32 checks passed
@andrey18106 andrey18106 deleted the feat/advanced-deploy-options branch January 20, 2025 20:21
@backportbot backportbot bot mentioned this pull request Jan 20, 2025
Merged
2 tasks
@Altahrim Altahrim mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyteinsky kyteinsky kyteinsky requested changes

@oleksandr-nc oleksandr-nc oleksandr-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrey18106 @kyteinsky @oleksandr-nc