Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): advanced deploy options #50230

Merged
merged 2 commits into from
Jan 20, 2025
Merged

feat(settings): advanced deploy options #50230

merged 2 commits into from
Jan 20, 2025

Conversation

andrey18106
Copy link
Contributor

@andrey18106 andrey18106 commented Jan 17, 2025 •
edited
Loading

Summary

This PR adds modal window to configure Deploy options for ExApps

1 2 3
image deploy_options_installed deploy_options_install_2

Checklist

@andrey18106 andrey18106 mentioned this pull request Jan 17, 2025
Merged
@andrey18106 andrey18106 force-pushed the feat/settings/advanced-deploy-options branch 2 times, most recently from cc2b48a to fc483fa Compare January 17, 2025 15:57
@andrey18106 andrey18106 force-pushed the feat/settings/advanced-deploy-options branch from 995ffb4 to d055a63 Compare January 20, 2025 09:27
@andrey18106 andrey18106 added this to the Nextcloud 31 milestone Jan 20, 2025
@andrey18106 andrey18106 requested a review from kyteinsky January 20, 2025 10:12
susnux
susnux requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use NcDialog for consistent design, then you also have to do much less custom styling ;)
Also the dialog content currently is not good for accessibility, I left some notes on it.

apps/settings/src/store/app-api-store.ts Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue Outdated Show resolved Hide resolved
@andrey18106 andrey18106 force-pushed the feat/settings/advanced-deploy-options branch 3 times, most recently from 7180276 to d23fb8d Compare January 20, 2025 12:51
oleksandr-nc
oleksandr-nc approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in terms of functionality - it works.

susnux
susnux approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessibility wise better ✅
Did not test with external apps though.

@andrey18106 andrey18106 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2025
@andrey18106
feat(app_api): Advanced deploy options
73c138b 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 force-pushed the feat/settings/advanced-deploy-options branch from a549e10 to 73c138b Compare January 20, 2025 17:26
@andrey18106
Copy link
Contributor Author

/compile

@andrey18106 andrey18106 enabled auto-merge January 20, 2025 17:27
@nextcloud-command
chore(assets): Recompile assets
7e5f5f3 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@andrey18106 andrey18106 merged commit 69ee366 into master Jan 20, 2025
120 checks passed
@andrey18106 andrey18106 deleted the feat/settings/advanced-deploy-options branch January 20, 2025 17:50
@Altahrim Altahrim mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-nc oleksandr-nc oleksandr-nc approved these changes

@susnux susnux susnux approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@kyteinsky kyteinsky Awaiting requested review from kyteinsky

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: apps management
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@andrey18106 @susnux @oleksandr-nc @nextcloud-command