Fix AdBlock blocking share icon #417
Conversation
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @tcitworld and @raghunayyar to be potential reviewers. |
|
Given the domains for this tool changes, no way to cover all instances. If nextcloud has changed the element from icon-share to icon-shared? does that fix it? |
templates/part.calendarlist.item.php
Outdated
| @@ -49,7 +49,7 @@ | |||
| ng-class="{'withitems': item.calendar.isShared() || item.calendar.isPublished() }"> | |||
| <span | |||
| class="calendarlist-icon share permanent" | |||
| ng-class="{'icon-shared': item.calendar.isShared() && !item.calendar.isPublished(), 'icon-public': item.calendar.isPublished(), 'icon-share': !item.calendar.isShared() && !item.calendar.isPublished()}" | |||
| ng-class="{'icon-shared': item.calendar.isShared() && !item.calendar.isPublished(), 'icon-public': item.calendar.isPublished(), 'icon-shared': !item.calendar.isShared() && !item.calendar.isPublished()}" | |||
There was a problem hiding this comment.
@georgehrke could you please look into this? The images share.svg and shared.svg are exactly the same. They if shared or not should only differ in opacity of the icon, like in Files.
|
@georgehrke @raghunayyar can you check this out so it’s ready for Nextcloud 12? :) |
|
Any review please @kumzugloom @Pommesumdreher @MariusBluem @Bullnados @GetBoz @georgehrke @MariusBluem? |
|
Jan, stay calm :)
The calendar is not affected by today's feature freeze. I will merge this before we release the next calendar version
Please excuse my brevity and typos.
Sent from my mobile
… On Apr 26, 2017, at 6:14 PM, Jan-Christoph Borchardt ***@***.***> wrote:
Any review please @kumzugloom @Pommesumdreher @MariusBluem @Bullnados @GetBoz @georgehrke @MariusBluem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I know, still it’s good practice do do this as early as possible. ;) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
fix-adblock-share-icon
branch
from
6e42479
to
bd7160f
Compare
|
Fixed the styles: |
Same as nextcloud/server#4337, but for the share icons in the Calendar.
Please review @kumzugloom @Pommesumdreher @MariusBluem @Bullnados @GetBoz @georgehrke @MariusBluem :)