Calendar Share Functionality missing

[kumzugloom]

Steps to reproduce

When I create calendars with one user, I'd like to share them with another user or even publicly. This was possible in OC9, however, I cannot find the button in the "edit calendar" section, I can only change color and name there.

Expected behaviour

Users should be able to share their calendars with other users.
(As described in https://nextcloud.com/features/#calendarcontacts: "Private and shared calendars and addressbooks with permissions management")

Actual behaviour

Users cannot share their calendars.

Server configuration

Operating system:
Raspbian

Web server:
Nginx

Database:
SQLite

PHP version:
PHP 5.6.24-0+deb8u1

Nextcloud version: (see Nextcloud admin page)
Nextcloud 9.0.50 (stable)

Updated from an older Nextcloud/ownCloud or fresh install:
Fresh install

Where did you install Nextcloud from:
Nextcloud.com

[MariusBluem]

Nextcloud 9 can share calendar as ownCloud 9 too 😁 ... I'll try to assist you solving this bug:

Seems to be a calendar-app issue, which has nothing to do with the Nextcloud Server. Could you provide me a screenshot from Nextcloud 9 with the missing sharing dialog and ownCloud 9.0 with the sharing dialog ... Were ownCloud and Nextcloud configured in the same way, on the same Raspberry Pi and did you used the same browser? 😁 ... Can you use CalDAV Clients to do that operations?!

[kumzugloom]

Hi @Mar1u5,
thanks for your quick reply. Yes, it seems to be a calendar app issue, but i did not found the nextcloud calendar app bugtracker. Therefore I thought it might be maintained in here as well.

Here you have the screenshot not showing the dialog:

I have Thunderbird Lightning on Windows and DAVDroid on Android as Clients. Syncronizing works fine, but I cannot change permissions of calendars in those clients.

I created this Raspberry completely from scratch, so there might be slight differences in the configuration, but currently I don't know them. I'll try to investigate further.

[Pommesumdreher]

Do you use Adblock? I had the same Problem, disabling it for Nextcloud solved it.

[MariusBluem]

THX @Pommesumdreher 👊

I can reproduce this when I activate AdBlock Plus 😈 Try whether this solves the problem for you - and report back @kumzugloom ;) (Ref: owncloud/calendar#235)

... Contacts / Calendar and Mail repositories (with the bugtracker) are currently in ownCloud 😉
Thats the confusion I've talked about to you @jancborchardt @karlitschek

I'll close this issue here for now, because this is the server and not the calendar 😁
If you are still experiencing problems with the calendar (not AdBlocker related) - please open a new issue here:
https://github.com/owncloud/calendar

The new issue you open in owncloud/calendar should contain the link to this issue as a reference, and please mention me with "@Mar1u5" too, so that I am informed about the status of your issue 😼

[kumzugloom]

Thanks a lot @Pommesumdreher and @Mar1u5!
That was exactly the problem. Thank you also for pointing me to the right direction regarding (potential) bug reports in the future. 👍

[jancborchardt]

@Mar1u5 @Pommesumdreher @kumzugloom does anyone of you want to take initiative on contacting AdBlock Plus to not block this? I think it has to do with the icon being named »share«. We need to have them add an exception so it’s not blocked in Nextcloud, especially as the audience of Nextcloud and Adblockers probably have quite some overlap.

[MariusBluem]

@jospoortvliet ... That could be a Job for you.

[jancborchardt]

@Mar1u5 @Pommesumdreher @kumzugloom or for you folks since you encounter the issue. ;) Remember Nextcloud is community-driven, and especially this shortly before the conf, Jos will have a bunch of other things to do. :)

[kumzugloom]

Hi @Mar1u5 @Pommesumdreher @jancborchardt,
you are probably correct. I just searched the relevant forums and was able to identify, that this issue was raised to AdBlock and EasyList. However, the response was (in short): "Won't fix, just rename your button."

Below you will find the links to the forums:
AdBlock Plus: https://adblockplus.org/forum/viewtopic.php?f=18&t=44184&p=148242&hilit=owncloud#p148242
Easylist: https://forums.lanik.us/viewtopic.php?f=64&t=28785

[jancborchardt]

Yeah, so the important one is this: https://forums.lanik.us/viewtopic.php?f=64&t=28785 – mind commenting if there can be a rule that Nextcloud/ownCloud are exempt from that icon blocking? Cause icon-share is also used by other frameworks and is kinda stupid to block for everyone.

[Bullnados]

Some news here?
Cause not only the calendar share button is affected also share button in nextcloud is affected

[Pommesumdreher]

Since Adblock added their own Ads, I switched to uBlock Origin. It works better for me and there are no problems with nextcloud ;)

[Bullnados]

I'm also using uBlock Origin and i still have the problem

[Pommesumdreher]

Which Version of uBlock Origin and Nextcloud do you use?

[Bullnados]

NC 11.0.2 and origin 1.11.4.
But no problem I whitelisted my NC instance

[Pommesumdreher]

Which browser do you use? I am using firefox (I have to leave my computer now, so I will answer a bit later)

[Bullnados]

ff 53 beta x64
Perhaps it is some of the block lists

[Pommesumdreher]

Yes, maybe. Do you have a Number in the Sign of uBlock Origin on the top right, when Nextcloud is open?

[Pommesumdreher]

If yes, what is listed under "blocked requests"?

[GetBoz]

In uBlock Origin, the share icon is hidden by the ##.icon-share filter of Fanboy's Lists

"Static filter ##.icon-share found in :"

[jancborchardt]

All fixed now! :) Please review #4337 and also the pull requests to Calendar nextcloud/calendar#417 and Contacts nextcloud/contacts#188 🎉

Sorry for the wait, and thanks for the help everyone!

[sebalis]

The share icons for unshared calendar items are still blocked by the “Fanboy’s Social” list on uBlock Origin in Nextcloud 17.0.3 (official Calendar app). No surprise because they use the class “icon-share”, not “icon-shared” as for unshared files or, indeed, shared calendars (so the share icons for all of these are not blocked).

[mc256]

ad block plus is also blocking this icon