Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of appointments booking page #4593

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 11, 2022

image

booking-scroll.webm
scroll-mobile.webm

@st3iny st3iny added design Related to design, interface, interaction design, UX, etc. enhancement New feature request regression Regression of a previous working feature labels Oct 11, 2022
@st3iny st3iny added this to the v4.0.0 milestone Oct 11, 2022
@st3iny st3iny self-assigned this Oct 11, 2022
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the enh/noid/improve-booking-page-new-design branch from af159b1 to 78c3ddc Compare October 11, 2022 13:56
@st3iny st3iny enabled auto-merge October 11, 2022 13:57
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 29.39% // Head: 29.73% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (78c3ddc) compared to base (d5dfb80).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4593      +/-   ##
============================================
+ Coverage     29.39%   29.73%   +0.34%     
- Complexity      330      338       +8     
============================================
  Files           220      220              
  Lines          7703     7748      +45     
  Branches       1011     1011              
============================================
+ Hits           2264     2304      +40     
- Misses         5439     5444       +5     
Flag Coverage Δ
javascript 20.48% <ø> (ø)
php 69.41% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/views/Appointments/Booking.vue 0.00% <ø> (ø)
.../calendar/lib/Service/Appointments/MailService.php 98.03% <0.00%> (-1.97%) ⬇️
...lendar/lib/Service/Appointments/BookingService.php 82.05% <0.00%> (-1.95%) ⬇️
...lib/Service/Appointments/BookingCalendarWriter.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st3iny st3iny merged commit 4b5bec4 into main Oct 11, 2022
@st3iny st3iny deleted the enh/noid/improve-booking-page-new-design branch October 11, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to design, interface, interaction design, UX, etc. enhancement New feature request regression Regression of a previous working feature
Projects
Development

Successfully merging this pull request may close these issues.

3 participants