Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NcGuestContent for public appointment pages #4640

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 18, 2022

Requires nextcloud-libraries/nextcloud-vue#3369

Partially reverts #4628 and #4593

appointments.webm

@st3iny st3iny added technical debt blocked This ticket or PR is blocked by another one labels Oct 18, 2022
@st3iny st3iny self-assigned this Oct 18, 2022
@st3iny st3iny changed the title Use NcGuestContent for public appointments pages Use NcGuestContent for public appointment pages Oct 18, 2022
@st3iny st3iny force-pushed the enh/noid/use-nc-guest-content branch from e1efdb3 to 51c477b Compare October 18, 2022 10:17
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 41.30% // Head: 41.29% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (aa07e80) compared to base (9e8acdf).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4640      +/-   ##
============================================
- Coverage     41.30%   41.29%   -0.01%     
  Complexity      339      339              
============================================
  Files           226      226              
  Lines          5675     5676       +1     
  Branches        743      743              
============================================
  Hits           2344     2344              
- Misses         3331     3332       +1     
Flag Coverage Δ
javascript 31.15% <0.00%> (-0.01%) ⬇️
php 68.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/Appointments/AppointmentBookingConfirmation.vue 0.00% <ø> (ø)
src/views/Appointments/Booking.vue 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst
Copy link
Member

Related: #4638

@st3iny st3iny added 3. to review Waiting for reviews and removed blocked This ticket or PR is blocked by another one labels Dec 2, 2022
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the enh/noid/use-nc-guest-content branch from 51c477b to aa07e80 Compare December 2, 2022 09:34
@st3iny st3iny added this to the v4.2.0 milestone Dec 2, 2022
@st3iny st3iny marked this pull request as ready for review December 2, 2022 09:35
@st3iny st3iny merged commit 67d63b8 into main Dec 2, 2022
@st3iny st3iny deleted the enh/noid/use-nc-guest-content branch December 2, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants