-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: replace NcMultiselect with NcSelect #5323
Conversation
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
Before/after screenshot for the lazy people (me) pls :) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5323 +/- ##
============================================
+ Coverage 22.27% 22.36% +0.09%
Complexity 359 359
============================================
Files 236 236
Lines 11552 11554 +2
Branches 2248 2250 +2
============================================
+ Hits 2573 2584 +11
+ Misses 8979 8970 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/backport to stable4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice!
fix #5320