Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace NcMultiselect with NcSelect #5323

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

hamza221
Copy link
Contributor

fix #5320

Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added 3. to review Waiting for reviews bug labels Jun 16, 2023
@hamza221 hamza221 self-assigned this Jun 16, 2023
@ChristophWurst
Copy link
Member

Before/after screenshot for the lazy people (me) pls :)

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (1c029d1) 22.27% compared to head (236a14a) 22.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5323      +/-   ##
============================================
+ Coverage     22.27%   22.36%   +0.09%     
  Complexity      359      359              
============================================
  Files           236      236              
  Lines         11552    11554       +2     
  Branches       2248     2250       +2     
============================================
+ Hits           2573     2584      +11     
+ Misses         8979     8970       -9     
Flag Coverage Δ
javascript 14.00% <100.00%> (+0.11%) ⬆️
php 64.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../AppNavigation/EditCalendarModal/SharingSearch.vue 0.00% <ø> (ø)
src/mixins/EditorMixin.js 3.66% <100.00%> (+3.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristophWurst
Copy link
Member

/backport to stable4.4

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jun 16, 2023
@hamza221
Copy link
Contributor Author

BEFORE:
image

AFTER:
image

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 16, 2023
@ChristophWurst ChristophWurst enabled auto-merge June 16, 2023 15:23
@ChristophWurst ChristophWurst merged commit 30e4552 into main Jun 16, 2023
@ChristophWurst ChristophWurst deleted the fix/replace-mutiselect-sharin-search branch June 16, 2023 15:26
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Bug when adding users to a calendar / searchbar results
2 participants