-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't filter results while sharing #5645
Conversation
Signed-off-by: Akhil <akhil@e.email>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5645 +/- ##
============================================
- Coverage 24.45% 24.44% -0.01%
Complexity 418 418
============================================
Files 243 243
Lines 10833 10835 +2
Branches 1776 1776
============================================
Hits 2649 2649
- Misses 8184 8186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ChristophWurst Any update? It is crucial for me to allow share using email addresses :) I've tested the code and it works well. |
@akhil1508 Thank you for your contribution |
/backport to stable4.4 |
/backport to stable4.5 |
/backport to stable4.6 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Relates to #5691 Right now, one can only search for mail addresses and not for names nor groups. |
Share only works by display name right now
Search by email to share calendar is broken completely as there is a
filterBy
option in vue-select whose return value defaults toreturn (label || '').toLocaleLowerCase().indexOf(search.toLocaleLowerCase()) > -1
label
in our code is set todisplayName
so only search bydisplayName
worksSince we already get our results by searching(DAV & OCS), I don't see why we need the
filterBy
option in the first placetrue
displayName
andemail
attributes