Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add blank lines before returns and after control statements #32

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Signed-off-by: provokateurin <kate@provokateurin.de>
kesselb
kesselb previously approved these changes Sep 18, 2024
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Base automatically changed from enh/break-promoted-properties-on-multiline to master September 18, 2024 11:16
@ChristophWurst ChristophWurst dismissed kesselb’s stale review September 18, 2024 11:16

The base branch was changed.

@skjnldsv skjnldsv merged commit 67da46e into master Sep 18, 2024
2 checks passed
@skjnldsv skjnldsv deleted the feat/return-control-blank-lines branch September 18, 2024 11:48
@provokateurin provokateurin changed the title feat: Add rule for having one promoted property per line in constructor feat: Add blank lines before returns and after control statements Sep 18, 2024
@nickvergessen
Copy link
Member

I kind of disagree with this. it forces a lot of empty lines into code and can actually reduce the readability?

@ChristophWurst
Copy link
Member

Agree after seeing this in action 💔

@nickvergessen
Copy link
Member

In Talk it would add 997 new lines 😱

@provokateurin
Copy link
Member Author

can actually reduce the readability?

For personally not, as I always write my code with these newlines, but sure don't need to force everyone to have this style.
There seemed to be quite some agreement on this though, as the 3 needed reviews came in very fast and without any objections.

@ChristophWurst
Copy link
Member

the 3 needed reviews came in very fast and without any objections

approval under influence

@provokateurin
Copy link
Member Author

I didn't even look to your table xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants