-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add blank lines before returns and after control statements #32
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
The base branch was changed.
I kind of disagree with this. it forces a lot of empty lines into code and can actually reduce the readability? |
Agree after seeing this in action 💔 |
In Talk it would add 997 new lines 😱 |
For personally not, as I always write my code with these newlines, but sure don't need to force everyone to have this style. |
approval under influence |
I didn't even look to your table xD |
Based on #31 to avoid conflicts.
See
https://github.com/erickskrauch/php-cs-fixer-custom-fixers?tab=readme-ov-file#erickskrauchblank_line_before_return
and
https://github.com/erickskrauch/php-cs-fixer-custom-fixers?tab=readme-ov-file#erickskrauchline_break_after_statements.