Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact_space and nullable_type_declaration #33

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add contact_space and nullable_type_declaration #33

merged 1 commit into from
Sep 18, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 18, 2024

Based on #32 to avoid conflicts.

Close #29
Close #30

@kesselb kesselb self-assigned this Sep 18, 2024
@kesselb kesselb force-pushed the feat/concat_space_nullable_returns branch from 27a82a6 to 012e82b Compare September 18, 2024 11:31
ChristophWurst
ChristophWurst previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should introduce tests and fixtures

@kesselb kesselb dismissed ChristophWurst’s stale review September 18, 2024 11:51

The merge-base changed after approval.

provokateurin
provokateurin previously approved these changes Sep 18, 2024
View reviewed changes
@provokateurin
Copy link
Member

Diff looks weird because it also includes my already merged PR? Might be a Github problem though.

@kesselb kesselb dismissed provokateurin’s stale review September 18, 2024 11:59

The merge-base changed after approval.

@kesselb kesselb force-pushed the feat/concat_space_nullable_returns branch from 012e82b to 92003fa Compare September 18, 2024 12:42
@kesselb
style: add concat_space and nullable_type_declaration
d150d95 
Ref #29
Ref #30

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the feat/concat_space_nullable_returns branch from 92003fa to d150d95 Compare September 18, 2024 12:43
@come-nc come-nc merged commit 56441b3 into master Sep 18, 2024
2 checks passed
@come-nc come-nc deleted the feat/concat_space_nullable_returns branch September 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst left review comments

Assignees

@kesselb kesselb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal concat_space Rule proposal nullable_type_declaration
5 participants
@kesselb @provokateurin @nickvergessen @ChristophWurst @come-nc