Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autofocus when opening new page in edit mode #596

Closed
max-nextcloud opened this issue Mar 9, 2023 · 0 comments · Fixed by #929
Closed

Do not autofocus when opening new page in edit mode #596

max-nextcloud opened this issue Mar 9, 2023 · 0 comments · Fixed by #929
Labels
enhancement New feature or request

Comments

@max-nextcloud
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
the other day when using the search in Collectives, with the last 2 characters it somehow switched to editing the current page (was the main page) and typed it in there instead.
It was possibly cause the collective was not completely loaded yet. So when the page was loaded it took the focus away from the search entry.

Describe the solution you'd like
When you start Collectives in edit mode, it’s fine if you have to click inside the content first. When you click on "Edit", then autofocus is expected

Describe alternatives you've considered
I think detecting situations where the focus is in a different text entry and not stealing focus then would be difficult as tiptap simply has an autofocus parameter that we set when starting to load the editor.

Additional context
First reported by @jancborchardt in office public chat.

@max-nextcloud max-nextcloud added the enhancement New feature or request label Mar 9, 2023
mejo- added a commit that referenced this issue Oct 5, 2023
Fixes: #596

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Oct 5, 2023
Fixes: #596

This might also help with flakyness of some Cypress tests.

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Oct 5, 2023
Fixes: #596

This might also help with flakyness of some Cypress tests.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- closed this as completed in 75ce586 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant