fix(TextEditor): don't autofocus editor when loading in edit mode #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/no_focus_editor
branch
from
682735f to
be75135
Compare
2 failed and 2 flaky tests on run #1183 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Output
Screenshots
|
|
page-details.spec.js • 1 flaky test • Nextcloud stable25
| Test | Artifacts | |
|---|---|---|
| Page details > Display table of contents > Allows to display/close TOC and switch page modes in between |
Output
Screenshots
|
|
Review all test suite changes for PR #929 ↗︎
max-nextcloud
approved these changes
Oct 9, 2023
Fixes: #596 This might also help with flakyness of some Cypress tests. Signed-off-by: Jonas <jonas@freesources.org>
* Use `newPageContent` if a new page is created (regardless whether template or not). * Use `newPageTitle` to indicate that the new page needs a title (in case it's not a template). * Move logic to set `newPageContent` to `done` into TextEditor component, to make sure we always load the editor for new page content. Should fix the flakyness of Cypress test 'New page has template content'. Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
force-pushed
the
fix/no_focus_editor
branch
from
d69c404 to
fae3f59
Compare
mejo-
added a commit
that referenced
this pull request
Oct 10, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Oct 10, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Oct 10, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Oct 11, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Oct 31, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 1, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 1, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 6, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 6, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 6, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 7, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
added a commit
that referenced
this pull request
Nov 8, 2023
Incorporate changes from #929 into new component. Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #596
This might also help with flakyness of some Cypress tests.