Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply to new resizeable list feature #2246

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Comply to new resizeable list feature #2246

merged 1 commit into from
Jun 18, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 3, 2021 •
edited
Loading

@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress labels Jun 3, 2021
@skjnldsv skjnldsv added this to the next major milestone Jun 3, 2021
@skjnldsv skjnldsv self-assigned this Jun 3, 2021
@skjnldsv skjnldsv force-pushed the feat/resizeable-list branch 2 times, most recently from 64e3cae to 215e68a Compare June 3, 2021 16:49
@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #2246 (5d0b187) into master (33c4413) will not change coverage.
The diff coverage is n/a.

❗ Current head 5d0b187 differs from pull request most recent head 6539c32. Consider uploading reports for the commit 6539c32 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2246   +/-   ##
=========================================
  Coverage     69.55%   69.55%           
  Complexity      238      238           
=========================================
  Files            22       22           
  Lines           680      680           
=========================================
  Hits            473      473           
  Misses          207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c4413...6539c32. Read the comment docs.

@ChristophWurst ChristophWurst mentioned this pull request Jun 10, 2021
Closed
1 task
@skjnldsv skjnldsv force-pushed the feat/resizeable-list branch from 215e68a to 6408f57 Compare June 10, 2021 08:14
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2021
@skjnldsv skjnldsv force-pushed the feat/resizeable-list branch from 6408f57 to 55bce1f Compare June 10, 2021 08:51
GretaD
GretaD approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and it works

@ChristophWurst ChristophWurst mentioned this pull request Jun 18, 2021
Merged
@skjnldsv
Comply to new resizeable list feature
6539c32 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/resizeable-list branch from 55bce1f to 6539c32 Compare June 18, 2021 10:50
@skjnldsv
Copy link
Member Author

Rebased, thanks Greta 🤗

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 18, 2021
@skjnldsv skjnldsv merged commit 4d9fc5f into master Jun 18, 2021
@skjnldsv skjnldsv deleted the feat/resizeable-list branch June 18, 2021 10:57
@skjnldsv skjnldsv modified the milestones: next major, 4.0.0 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @GretaD