Hide social sync option if social sync is not available

[pboguslawski]

This mod hides Update avatars from social media (refreshed once per week)
checkbox from contacts settings if syncing avatars is disabled by admin
or no internet connection is avalable.

Author-Change-Id: IB#1125033
Related: #1594
Signed-off-by: Pawel Boguslawski pawel.boguslawski@ib.pl

[call-me-matt]

code looks good, thank you for this improvement!
not sure if it is good practice to add your copyright to all the files where you have added a word.

[call-me-matt]

triple copyright and no https? 😛

[pboguslawski]

https://github.com/nextcloud/server/blob/master/contribute/HowToApplyALicense.md

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.33%. Comparing base (030d2d5) to head (2b3d45e).
Report is 857 commits behind head on main.

❗ Current head 2b3d45e differs from pull request most recent head b741dd6. Consider uploading reports for the commit b741dd6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #2913      +/-   ##
==========================================
+ Coverage     5.17%   8.33%   +3.15%     
==========================================
  Files          110      87      -23     
  Lines         1874    1164     -710     
  Branches       238     239       +1     
==========================================
  Hits            97      97              
+ Misses        1662     952     -710     
  Partials       115     115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristophWurst]

CI isn't happy :)

[miaulalala]

@pboguslawski ping :) can you fix the CI issues please?

you can lint with composer run cs:fix

and the SocialApiServiceTest fixing.

[pboguslawski]

you can lint with composer run cs:fix

Fixed in 3aaf6ef.

and the SocialApiServiceTest fixing.

Not sure why this test fails. Maybe has_internet_connection is false during this test and should be set to true for this test? Not experienced in nc unit tests devel so please suggest fix.

[ChristophWurst]

I'm trying to update the branch to get CI running. Unfortunately the settingssection component was remvoed with #3032.

[ChristophWurst]

I succeeded with the update but @pboguslawski's branch doesn't allow me to push.

@pboguslawski could you please update the branch yourself? You have to move the settingsection changes to src/components/AppNavigation/ContactsSettings.vue

[pboguslawski]

I succeeded with the update but @pboguslawski's branch doesn't allow me to push.

@pboguslawski could you please update the branch yourself? You have to move the settingsection changes to src/components/AppNavigation/ContactsSettings.vue

Fixed in 2b3d45e.

[hamza221]

@pboguslawski friendly ping to update the copyright section

Don't overwrite, add yours instead:

[pboguslawski]

Restored copyright note that was removed unintentionally (8f9d697).

[pboguslawski]

After further investigation, removed this copyright in b741dd6 because it should not be modified in this PR (removal was effect of main merge and there is no such copyright in main now. As you can see if Files changed, this PR only adds our Copyright now.