Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.4] Fix:deselect groups and groups update #3625

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #3605

Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working regression Regression of a previous working feature labels Sep 18, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the v5.4.0 milestone Sep 18, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamza221 let's get this released today

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.08% ⚠️

Comparison is base (9a885be) 2.07% compared to head (b4f1f2f) 0.00%.

❗ Current head b4f1f2f differs from pull request most recent head f5eb14f. Consider uploading reports for the commit f5eb14f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             stable5.4   #3625      +/-   ##
==============================================
- Coverage         2.07%   0.00%   -2.08%     
- Complexity           0     260     +260     
==============================================
  Files               89      24      -65     
  Lines             5347     782    -4565     
  Branches          1491       0    -1491     
==============================================
- Hits               111       0     -111     
+ Misses            5118     782    -4336     
+ Partials           118       0     -118     

see 113 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 18, 2023
@alphasixtyfive
Copy link

Any chance for a release today?

@hamza221 hamza221 merged commit d7ee8ab into stable5.4 Sep 20, 2023
26 checks passed
@hamza221 hamza221 deleted the backport/3605/stable5.4 branch September 20, 2023 08:46
@st3iny st3iny modified the milestones: v5.4.0, v5.4.1 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants