Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.4] Fix:deselect groups and groups update #3625

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[stable5.4] Fix:deselect groups and groups update #3625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
<template #icon>
<IconMail :size="20" />
</template>
<ActionLink v-for="emailAddress in emailAddressList"

Check warning on line 231 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

Variable 'emailAddress' is already declared in the upper scope
:key="emailAddress"
:href="'mailto:' + emailAddress">
<template #icon>
Expand Down Expand Up @@ -304,7 +304,8 @@
:value.sync="localContact.groups"
:contact="contact"
:is-read-only="isReadOnly"
class="property--groups property--last" />
class="property--groups property--last"
@update:value="updateGroups" />
</div>
<!-- new property select -->
<AddNewProp v-if="!isReadOnly"
Expand Down Expand Up @@ -895,7 +896,7 @@
/**
* Update this.localContact and set this.fixed
*
* @param {Contact} contact the contact to clone

Check warning on line 899 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'Contact' is undefined
*/
async updateLocalContact(contact) {
// create empty contact and copy inner data
Expand Down Expand Up @@ -945,7 +946,7 @@
/**
* Should display the property
*
* @param {Property} property the property to check

Check warning on line 949 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'Property' is undefined
* @return {boolean}
*/
canDisplay(property) {
Expand Down Expand Up @@ -1030,9 +1031,6 @@
display: none;
}
}
::v-deep .vs__deselect {
display: none;
}
#pick-addressbook-modal {
::v-deep .modal-container {
display: flex;
Expand Down
Loading