Import file FileAction 28 compatibility #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3669 +/- ##
==========================================
- Coverage 2.07% 0.00% -2.08%
- Complexity 0 261 +261
==========================================
Files 89 24 -65
Lines 5343 784 -4559
Branches 1491 0 -1491
==========================================
- Hits 111 0 -111
+ Misses 5114 784 -4330
+ Partials 118 0 -118
☔ View full report in Codecov by Sentry. |
GretaD
commented
Oct 19, 2023
GretaD
force-pushed
the
migrate/contacts-newfile-api
branch
from
3b66493 to
809e787
Compare
GretaD
added
3. to review
GretaD
commented
Oct 26, 2023
st3iny
reviewed
Oct 26, 2023
ChristophWurst
previously requested changes
Oct 31, 2023
st3iny
reviewed
Nov 1, 2023
st3iny
approved these changes
Nov 1, 2023
st3iny
added
4. to release
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
migrate/contacts-newfile-api
branch
from
20b4bee to
5493404
Compare
skjnldsv
reviewed
Nov 3, 2023
| if (method_exists(Util::class, 'addInitScript')) { | ||
| Util::addInitScript(Application::APP_ID, 'contacts-files-action'); | ||
| } else { | ||
| Util::addScript(Application::APP_ID, 'contacts-files-action'); |
There was a problem hiding this comment.
Suggested change
| Util::addScript(Application::APP_ID, 'contacts-files-action'); | |
| Util::addScript(Application::APP_ID, 'contacts-files-action', 'files'); |
skjnldsv
reviewed
Nov 3, 2023
| } | ||
| console.error('Unable to register vcf import action') | ||
| }) | ||
| if (nextcloudVersionIsGreaterThanOr28) { |
There was a problem hiding this comment.
I am not even sure this is needed. Worse case this will register an unused action 🤷
skjnldsv
reviewed
Nov 3, 2023
| id: name, | ||
| displayName: () => t('contacts', 'Import'), | ||
| default: DefaultType.DEFAULT, | ||
| mime, |
skjnldsv
reviewed
Nov 3, 2023
| default: DefaultType.DEFAULT, | ||
| mime, | ||
| enabled: (nodes) => { | ||
| return nodes.every((node) => node.mime === mime && (node.permissions & Permission.READ)) |
There was a problem hiding this comment.
Using some with the opposite check is faster as it fill stop at the first false return
Something like
Suggested change
| return nodes.every((node) => node.mime === mime && (node.permissions & Permission.READ)) | |
| return nodes.some((node) => node.mime !== mime || (node.permissions & Permission.READ) === 0) |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3621