Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the permission check on files-actions #3690

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 3, 2023

@GretaD GretaD added the 3. to review Waiting for reviews label Nov 3, 2023
@GretaD GretaD requested review from st3iny and skjnldsv November 3, 2023 09:30
@GretaD GretaD self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1611f5e) 2.06% compared to head (af8a5b7) 0.00%.

❗ Current head af8a5b7 differs from pull request most recent head 7cd9992. Consider uploading reports for the commit 7cd9992 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3690      +/-   ##
==========================================
- Coverage     2.06%   0.00%   -2.07%     
- Complexity       0     261     +261     
==========================================
  Files           89      24      -65     
  Lines         5365     784    -4581     
  Branches      1504       0    -1504     
==========================================
- Hits           111       0     -111     
+ Misses        5134     784    -4350     
+ Partials       120       0     -120     
Files Coverage Δ
lib/Listener/LoadContactsFilesActions.php 0.00% <0.00%> (ø)

... and 112 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/files-action.js Outdated Show resolved Hide resolved
@GretaD GretaD requested a review from ChristophWurst November 6, 2023 13:47
@GretaD GretaD changed the title Use 'some' instead of 'every' for the permission check on files-actions Fix the permission check on files-actions Nov 6, 2023
src/files-action.js Outdated Show resolved Hide resolved
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the migrate/file-action-28 branch from 1b77dd7 to 7cd9992 Compare November 8, 2023 16:31
@GretaD GretaD enabled auto-merge November 8, 2023 16:31
@GretaD GretaD merged commit ee23a39 into main Nov 8, 2023
26 checks passed
@GretaD GretaD deleted the migrate/file-action-28 branch November 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants