Crash during sync due to CLDAPI.dll error #3349
Comments
|
Same issue here. OS : Windows 10 (21390) Windows Event vewer log
Nextcloud app log
Nextcloud folder log
My initial thought had been if the file had been i use or corrupt could have caused the issue. but ruled out corruption very quickly with another instance of the server and multiple folders and sizes of folders and files. i had noticed "folderwatcher" so had disabled AV but issue is still persistent. I have noticed that the DB can fail to write quite a lot although the app can crash before a DB write error occurs. @burakkaraceylan Do you get the "error writing metadata to database" error in the settings panel?
Any ideas on what to try next? happy to try and help |
|
I've run into this as well. Digging in a bit, it's crashing here: Here's a bit more debug info: I tried building nextcloudsync.dll with optimizations disabled /Od to get more info but it's not crashing and instead giving sync errors: |
Fixes nextcloud#3349 Signed-off-by: James Horsley <jbhorsley@gmail.com>
|
Same issue on 3.2.3 for me: Windows Event vewer log We all seem to be on Insider Preview Builds seems like the app doesn't like newer versions of CLDAPI.dll |
I was running into this issue when I was on Windows 10 as well. My account was part of the Windows Insider program, but my machine was not subscribed to any flights at the time. Problem persists into Windows 11. |
|
Still an issue for me with 3.2.4 |
Fixes nextcloud#3349 Signed-off-by: James Horsley <jbhorsley@gmail.com>
|
Also an issue on my Win 10 I tried looking at the nextcloud desktop client log file, after reaching some 500MB of logs checking files upon startup, the client crashes and there is nothing in the log that looks to be helpful, it just stops. Doesn't look like there are relevant messages on the server either. This is a reliable crash on the most recent desktop client. |
|
same here:
|
|
(Same) |
|
Just installed the client on W11 and yeah, crashes for me after creating some virtual files... |
|
I had the same behavior of the app on stable w10. But maybe it had another reason? Can someone still confirm this bug on a regular w10 build? |
Fixes nextcloud#3349 Change placeholder functions to take QStrings instead of handles Signed-off-by: James Horsley <jbhorsley@gmail.com>
|
@LucaOverflow yes its on regular Windows 10 2H1 (build 19043.1147) |
Fixes #3349 Change placeholder functions to take QStrings instead of handles Signed-off-by: James Horsley <jbhorsley@gmail.com>
|
You may want to try this build with a potential fix to CLDAPI from @mmdanggg2 Updated Link: https://cloud.nextcloud.com/s/JGj2FXW5mTGqmPj |
|
The Client isn't crashing anymore. But at least for the last 30 minutes it isn't syncing as well. I will let it run for now.. maybe it will sync after a while. Edit: |
|
fixed for me. Thx for sharing. Runs for half hour stable. Can u provide a MergeRequest for this Build? |
|
@LucaOverflow I am wondering if there is a pattern for those files. Do they have something in common? Those with |
|
@4iter4life This is the original PR by @mmdanggg2 #3461 Currently it is under review and I hope we can merge it sooner as I can see it does fix an issue for you and for @LucaOverflow. I will just need to dig deeper into an issue that @LucaOverflow is having. |
|
The issue has existed for a long time so I don't think switching back to an old CLDAPI.DLL would help. Also, trying to cherrypick/replace DLL files in C:\Windows\System32 is probably asking for trouble. After reading through the excellent investigation by @mmdanggg2 and the win32 api documentation, I believe this behaviour in intentional by Microsoft. SOMETHING is causing the OpLock to be broken and the client is supposed to handle this, however it is not clear to me how to check for an OpLock break. Compare for example the description of Opportunistic locking in the SMB protocol (https://en.wikipedia.org/wiki/Server_Message_Block#Opportunistic_locking). |
|
@dsahlberg-apache-org Probably so, but as it is spreading quickly I'm at a point where mass installing the client is the only option left (this crash blocks almost everything in explorer, also access to SMB shares). So before I take that drastic decision, I rather experiment on a VM which can easily be reverted. |
|
Is there any reason why the cherry-picked CLDAPI.DLL can't go into the same directory as nextcloud.exe? It's not a protected "known DLL" that Windows always force-loads from a known location, so having it in the same directory as nextcloud.exe should load that particular version of the DLL instead of the system one. It would be much safer than trying to replace the copy in System32. |
|
@coldacid I don't think so because if I understand it correctly, it's used for the interaction between windows explorer and the Nextcloud client. So both will have to use it. |
|
With how dynamic linking works on NT-based Windows, there's no sharing loaded DLLs between different processes. This would be an issue if the client was running within the Explorer process, but running in its own process it can have its own copy of a DLL. |
|
Sorry to ping again, but is there anything more we can test? |
|
+1, please give this ticket priority. Its critical. |
|
Latest version essentially crashes on start now on my Windows 10 computer. On the other hand, it runs like a beauty on my new Windows 11 device. Unfortunately, it's the former I use the most. |
|
Is there a possible link with the #4226 bug ? |
Yes, I think it's caused by the same |
|
@mgallien Any new builds we can test? |
|
I notice, during a sync that crashed, some kind of memory leak. |
I guess the memory leak can be a consequence of the missing handle. I don't think it is the cause of the crashes |
Fixes nextcloud#3349 Change placeholder functions to take QStrings instead of handles Signed-off-by: James Horsley <jbhorsley@gmail.com>
|
@mgallien Does that mean we have a confirmed fix!? |
|
I did a new build of a version that may work fine |
|
Testing on: Clean installation. By the moment it is going well. Maybe this is the solution.
|
It’s also working for me! |
|
Oh wow will test it these days as I'm currently drunk at an Greek beach. Sounds perfect, thanks for the effort |
It not only seems to work fine, it is X times faster even on a new install... |
|
Under test in production enviroment. Looks good! no crashes at the time (about 6 hours of heavy load) |
|
It could not have been a better timing, it's rolling out to all my clients today. |
|
So I am wondering, is the intention to have this merged into upstream and have it roll out with the official binaries? It is working great for me, but security-wise I would feel much better with the official binary (no offense, but you know how it goes, especially when you have secops asking about where is this binary coming from, etc). |
Fixes nextcloud#3349 Change placeholder functions to take QStrings instead of handles Signed-off-by: James Horsley <jbhorsley@gmail.com>
For me, it can solve the #4410 this problem， |
|
Same here. The pin state error is gone on my PC that had it after installing that build. |
Fixes nextcloud#3349 Change placeholder functions to take QStrings instead of handles Signed-off-by: James Horsley <jbhorsley@gmail.com>
Has this been merged into the official release? I'm still getting crashes on windows 11 and the link posted earlier is broken.
|
and others
Expected behaviour
Should sync the files.
Actual behaviour
Crashes.
Steps to reproduce
Client configuration
Client version: 3.2.1
Operating system: Windows 10 Build 19043
OS language: Turkish
Installation path of client: C:\Program Files\Nextcloud\nextcloud.exe
Logs
In the debugger the error comes down to:
cldapi.dll;IssueHsmControl()
"Unhandled exception at 0x00007FF8BFD24B2A (cldapi.dll) in nextcloud.exe: 0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFE."
The text was updated successfully, but these errors were encountered: