Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in cldapi.dll #3623

Closed
wants to merge 4 commits into from
Closed

Conversation

allexzander
Copy link
Contributor

Fixes #3349

Change placeholder functions to take QStrings instead of handles

Signed-off-by: James Horsley jbhorsley@gmail.com

@allexzander allexzander force-pushed the bugfix/mmdanggg2-fix-cldapi-crash branch from c5f87fe to 3023f58 Compare August 6, 2021 10:46
@allexzander allexzander force-pushed the bugfix/mmdanggg2-fix-cldapi-crash branch from 3023f58 to c7354ec Compare August 27, 2021 09:08
@allexzander allexzander force-pushed the bugfix/mmdanggg2-fix-cldapi-crash branch from c7354ec to f567142 Compare September 6, 2021 07:51
mmdanggg2 and others added 4 commits October 18, 2021 10:31
Fixes #3349

Change placeholder functions to take QStrings instead of handles

Signed-off-by: James Horsley <jbhorsley@gmail.com>
Signed-off-by: allexzander <blackslayer4@gmail.com>
Signed-off-by: allexzander <blackslayer4@gmail.com>
This reverts commit 204d7ef.

Signed-off-by: allexzander <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/mmdanggg2-fix-cldapi-crash branch from f567142 to 2527fcc Compare October 18, 2021 07:32
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3623-2527fccf6b8acbd747a8e2d0adb2d622272dfdbd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@allexzander allexzander deleted the bugfix/mmdanggg2-fix-cldapi-crash branch December 16, 2021 16:46
@allexzander allexzander restored the bugfix/mmdanggg2-fix-cldapi-crash branch December 16, 2021 16:47
@allexzander allexzander reopened this Dec 16, 2021
@gvansanden
Copy link

Any chance that this can be revisited? Windows 10 client is becoming increasingly unusable

@Rello
Copy link
Contributor

Rello commented Dec 3, 2024

Hello,

Thank you for your contribution to the Desktop Client with this pull request.
We are closing this request as it is outdated, no longer relevant (e.g., due to Qt 6), or does not align with the current roadmap.

We truly value your support and hope to see more contributions from you in the future!

Best regards,
Nextcloud Desktop Team

@Rello Rello closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during sync due to CLDAPI.dll error
6 participants