Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid error when doing hydration when data socket is closed too early #3501

Merged
merged 2 commits into from
Jul 6, 2021
Merged

avoid error when doing hydration when data socket is closed too early #3501

merged 2 commits into from
Jul 6, 2021

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jul 1, 2021

when data is received, if we close the socket they cannot be read

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien
Copy link
Collaborator Author

mgallien commented Jul 2, 2021

/rebase

@github-actions github-actions bot force-pushed the bugfix/fixImplicitHydration branch from 3dd0faa to 9c7d3e1 Compare July 2, 2021 08:13
@allexzander allexzander self-requested a review July 2, 2021 09:03
@mgallien mgallien force-pushed the bugfix/fixImplicitHydration branch 2 times, most recently from 7ebf690 to adaa594 Compare July 5, 2021 21:44
@mgallien
Copy link
Collaborator Author

mgallien commented Jul 6, 2021

/rebase

@mgallien
Copy link
Collaborator Author

mgallien commented Jul 6, 2021

/backport to stable-3.2

@github-actions github-actions bot force-pushed the bugfix/fixImplicitHydration branch from adaa594 to dc17a59 Compare July 6, 2021 09:36
@mgallien
Copy link
Collaborator Author

mgallien commented Jul 6, 2021

/rebase

mgallien added 2 commits July 6, 2021 14:16
@mgallien
avoid error when doing hydration when data socket is closed too early
4016c2f 
when data is received, if we close the socket they cannot be read

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
address review comments
c123edb 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@github-actions github-actions bot force-pushed the bugfix/fixImplicitHydration branch from dc17a59 to c123edb Compare July 6, 2021 14:16
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3501-c123edb1733683c0e003001e708af5ab3a8b35eb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 4848f95 into master Jul 6, 2021
@mgallien mgallien deleted the bugfix/fixImplicitHydration branch July 6, 2021 14:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 6, 2021
Merged
@allexzander allexzander mentioned this pull request Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@FlexW FlexW Awaiting requested review from FlexW

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @camilasan @allexzander