Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase login dialog button text to be in line with clients on other platforms #4637

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 13, 2022

Screenshot 2022-06-13 at 15 42 01

Closes #3693

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jun 13, 2022
@claucambra claucambra force-pushed the bugfix/rephrase-login-dialog branch 4 times, most recently from e8c42e7 to 5766fe0 Compare June 13, 2022 13:10
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #4637 (5766fe0) into master (49b2c5a) will not change coverage.
The diff coverage is n/a.

❗ Current head 5766fe0 differs from pull request most recent head 8267136. Consider uploading reports for the commit 8267136 to get more accurate results

@@           Coverage Diff           @@
##           master    #4637   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         138      138           
  Lines       17070    17070           
=======================================
  Hits         9631     9631           
  Misses       7439     7439           

@claucambra claucambra requested a review from jancborchardt June 13, 2022 16:17
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@mgallien mgallien requested a review from nimishavijay June 14, 2022 10:25
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! :) 🚀

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/rephrase-login-dialog branch from 5766fe0 to 8267136 Compare June 15, 2022 10:52
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4637-8267136013ea9a45b301c7271b3fa8c816d4d862-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit defdb00 into master Jun 15, 2022
@claucambra claucambra deleted the bugfix/rephrase-login-dialog branch June 15, 2022 11:32
@mgallien mgallien added this to the 3.6.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rephrase login dialog as most users do not own/control the server
4 participants