Replace private API QZipWriter with KArchive #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
force-pushed
the
bugfix/karchive
branch
from
ac46d68 to
4266b1c
Compare
|
@claucambra This KF5Archive seems to be unavailable on our CI (both drone and Windows). |
claucambra
force-pushed
the
bugfix/karchive
branch
from
4266b1c to
79ee85d
Compare
A patch do add it to the docker CI is merged, just opened nextcloud/desktop-client-blueprints#4 to add it to our Craft blueprint, merging #4704 should also fix issues |
claucambra
force-pushed
the
bugfix/karchive
branch
6 times, most recently
from
9200364 to
d4a8b7f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #4768 +/- ##
==========================================
- Coverage 57.15% 56.79% -0.36%
==========================================
Files 138 138
Lines 17135 17143 +8
==========================================
- Hits 9794 9737 -57
- Misses 7341 7406 +65
|
allexzander
approved these changes
Aug 5, 2022
mgallien
requested changes
Sep 7, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/karchive
branch
from
de9d8b6 to
9a0753d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
AppImage file: nextcloud-PR-4768-9a0753dabb061b4e3ac753cbdfd272d9bb256212-x86_64.AppImage |
8 tasks
mdkcore0
added a commit
to mdkcore0/void-packages
that referenced
this pull request
Feb 23, 2023
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
mdkcore0
added a commit
to mdkcore0/void-packages
that referenced
this pull request
Mar 7, 2023
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
paper42
pushed a commit
to void-linux/void-packages
that referenced
this pull request
Mar 9, 2023
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
kaistian
pushed a commit
to kaistian/void-packages
that referenced
this pull request
Mar 13, 2023
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt doesn't provide any public utilities for creating ZIP archives, and by using QZipWriter we are at the mercy of this API changing without warning. From
qzipwriter.h:KArchive exists as a Qt add-on that should let us easily replace our use of QZipWriter without dragging in any other dependencies. This will likely require a small addition to our build andCI infra to add KArchive to our CMake build, but it should fully eliminate the risk of depending on the private API.
Fixes #3723
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com