makes Qt WebEngine optional only on macOS #4875
Conversation
|
@mgallien I was too quick to approve. It is failing on drone. |
The goal is to improve the summary at end of configure time when running |
mgallien
force-pushed
the
bugfix/webEngineOptionalOnAppleOnly
branch
from
a841925 to
b01309f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
==========================================
+ Coverage 57.15% 57.22% +0.06%
==========================================
Files 138 138
Lines 17135 17146 +11
==========================================
+ Hits 9794 9811 +17
+ Misses 7341 7335 -6
|
@claucambra so do you want changes or do you approve ? |
approved :) |
should avoid distributing broken builds missing out web flow login that is required by some cusotmers Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/webEngineOptionalOnAppleOnly
branch
from
b01309f to
b81cdf1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-4875-b81cdf177d3410db45e6f97eb3575ceddabb73dd-x86_64.AppImage |
|
Requiring webengine makes it impossible to build/use the client on libre distributions like Parabola. Is there a way to build the client without it, since it can mostly work fine without webengine? |
|
does the build strictly require webengine? - the last i remember, it was intentionally made to avoid that a few years ago - there have been multiple discussions and pull requests about this ( #932 #1808 #856 #2204 #3353 ) - there was even a 'no-webengine' branch at one time working toward that goal - why does this keep creeping back in? - did someone leave the barn door open? |
|
On CRUX I used to make qtwebengine (especially the qt5 version...) optional, see this commit @mgallien @claucambra Is there any reason why everybody wants to hard depend on that? It's a huge dependency with a lot of pitfalls, it would be great to be able to avoid it. Maybe a flag to optionally disable it? |
|
important features do not work without QtWebEngine (may be required for users to login to a Nextcloud server) |
May be, but doesn't have to be, correctly? |
|
a flag to disable qtwebengine requirement would work for me and probably @bill-auger and @sseneca as well, it can still demand it by default. How do you feel about that @mgallien? |
I've been using the Nextcloud client with my Nextcloud instance for a while now, without qtwebengine installed :) So it works fine for me.
+1 on this, just having built-in support to opt-out from the webengine dependency would be really nice. |
may work |
|
I for one can not provide a complete PR for that.. |
|
as long as the client (without webengine) can be configured for and be
usable with an arbitrary self-hosted instance, that is sufficient for
our user-base
many people prefer lean software, which does only the minimum that it
needs to do, using the minimum of machine resources - optional and
bloated features could/should be plugins, for those who have the
use-case for the extra features
|
|
this also breaks building on some targeted architectures on void-linux; can we have a flag to disable the use of webengine? |
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
Also: - Add karchive as dependency [1] - Add patch to revert mandatory WebEngine dependency [2] [1] nextcloud/desktop#4768 [2] nextcloud/desktop#4875
should avoid distributing broken builds missing out web flow login that
is required by some cusotmers
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com