Fix 'Reply' primary property. #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2022 15:17
Signed-off-by: Camila <hello@camila.codes>
Primary is set to true when object type is 'room' or 'chat' and it set to false when object type is 'call'. Signed-off-by: Camila <hello@camila.codes>
camilasan
requested review from
mgallien,
allexzander,
claucambra,
jancborchardt and
nimishavijay
jancborchardt
approved these changes
Sep 29, 2022
claucambra
approved these changes
Sep 29, 2022
Signed-off-by: Camila <hello@camila.codes>
what about this? (with recent changes we kinda 'disappeared' with the button... 🙈 ) |
|
SonarCloud Quality Gate failed. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
=======================================
Coverage 57.13% 57.13%
=======================================
Files 138 138
Lines 17221 17221
=======================================
Hits 9839 9839
Misses 7382 7382 |
|
AppImage file: nextcloud-PR-4985-1ccc170f91b6acc8b4e4f747c5a952300dec6d47-x86_64.AppImage |
|
/backport to stable-3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing what Jan pointed out:
In the case of call notifications, "Call back" would be primary, "Reply" secondary.
For messages, "Reply" should stay primary of course.
Originally posted by @jancborchardt in #4967 (comment)
during call:
after missing the call:
missed called in a chat room:
chat message:
