Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] Fix 'Reply' primary property. #5006

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4985

Camila added 3 commits October 4, 2022 11:49
Signed-off-by: Camila <hello@camila.codes>
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.

Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #5006 (f5731dc) into stable-3.6 (f141b3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.6    #5006      +/-   ##
==============================================
- Coverage       57.19%   57.18%   -0.02%     
==============================================
  Files             138      138              
  Lines           17153    17153              
==============================================
- Hits             9811     9809       -2     
- Misses           7342     7344       +2     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.28% <0.00%> (-0.30%) ⬇️
src/libsync/propagatedownload.cpp 65.03% <0.00%> (+0.14%) ⬆️

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5006-f5731dce029bd61ac37a575f3d6408d337e206c9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit e834a62 into stable-3.6 Oct 5, 2022
@mgallien mgallien deleted the backport/4985/stable-3.6 branch October 5, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants