Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] Refactor FolderMan's "Edit Locally" capabilities as separate class #5111

Merged
merged 9 commits into from
Oct 31, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5107

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.6.2 milestone Oct 29, 2022
@claucambra
Copy link
Collaborator

This is a required backport due to security improvements in this PR

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #5111 (a1c565a) into stable-3.6 (67ecebf) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a1c565a differs from pull request most recent head 13b7043. Consider uploading reports for the commit 13b7043 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.6    #5111      +/-   ##
==============================================
+ Coverage       57.16%   57.18%   +0.01%     
==============================================
  Files             138      138              
  Lines           17187    17187              
==============================================
+ Hits             9825     9828       +3     
+ Misses           7362     7359       -3     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (+0.14%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.65% <0.00%> (+0.45%) ⬆️

@claucambra claucambra force-pushed the backport/5107/stable-3.6 branch from a1c565a to b56390d Compare October 29, 2022 13:42
… separate methods

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…lderMan

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…to own class

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the backport/5107/stable-3.6 branch from b56390d to bbc35b3 Compare October 31, 2022 08:37
@mgallien mgallien self-requested a review October 31, 2022 08:38
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5111-13b704316393660556ce4c00d32c7a613330f18a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit 9c52bd8 into stable-3.6 Oct 31, 2022
@mgallien mgallien deleted the backport/5107/stable-3.6 branch October 31, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants