[stable-3.6] Refactor FolderMan's "Edit Locally" capabilities as separate class#5111

Merged

mgallien merged 9 commits intostable-3.6from backport/5107/stable-3.6

Oct 31, 2022

+580-191

Commits on Oct 31, 2022

Refactor large editFileLocally FolderMan method into smaller, clearer separate methods

claucambra
authored and
mgallien
committed
Refactor edit locally into its own class, rather than bolting onto FolderMan

claucambra
authored and
mgallien
committed
Verify token before checking disk or modifying state

claucambra
authored and
mgallien
committed
Don't show the user any potenitally questionable remote data

claucambra
authored and
mgallien
committed
Refactor edit locally handler management away from application and into own class

claucambra
authored and
mgallien
committed
Show edit locally loading dialog sooner, improve feedback for user

claucambra
authored and
mgallien
committed
Ensure the checkTokenJob object gets deallocated

claucambra
authored and
mgallien
committed
Rename EditLocallyHandler to EditLocallyJob

claucambra
authored and
mgallien
committed
remove use of attribute nodiscard
mgallien
committed