add ci test image for PHP 7.2 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
juliusknorr
approved these changes
Apr 2, 2020
kesselb
reviewed
Apr 18, 2020
| @@ -0,0 +1,9 @@ | |||
| FROM nextcloudci/php7.2:php7.2-13 | |||
There was a problem hiding this comment.
Why do you used a fixed version? I was wondering about that when adding xdebug again to some images. It's a nightmare ;) Given that images are only built on tagging using latest should be fine.
There was a problem hiding this comment.
we didn't use latest tag. I added it in some builds last month, but lots are missing
There was a problem hiding this comment.
Ah. I thought the latest tag is automatically done by docker ;) The good thing is you already added it to https://hub.docker.com/r/nextcloudci/php7.2/tags so we can use it 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for nextcloud/server#20037