Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use deprecated API for LDAP paged results #20037

Merged
merged 1 commit into from
Apr 15, 2020
Merged

do not use deprecated API for LDAP paged results #20037

merged 1 commit into from
Apr 15, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 19, 2020 •
edited
Loading

fixes #19127

Adds an adapter to serve old an new API. Lifted the Access class of the paged results state handling and left it all to the adapters.

  • adjust ldap_read, if applicable
  • clean up cookie handling bits in Access.php
  • find a way for offset handling with multiple bases
    • seems to work already, figure out why :) – fixed it a long time ago on a higher level :)
  • adapt unit tests
  • fix whatever makes old API integration tests fail
  • polish adapter interface
  • stash the commits

@blizzz

This comment has been minimized.

Sign in to view
@blizzz

This comment has been minimized.

Sign in to view
@blizzz

This comment has been minimized.

Sign in to view
@blizzz blizzz added this to the Nextcloud 19 milestone Mar 19, 2020
@blizzz blizzz force-pushed the fix/19127/deprecated-ldap_control_paged_result_1 branch 2 times, most recently from 0b3e41c to 265b999 Compare April 2, 2020 14:20
@blizzz blizzz marked this pull request as ready for review April 2, 2020 14:21
This was referenced Apr 2, 2020
Merged
Merged
@blizzz blizzz added the 3. to review Waiting for reviews label Apr 2, 2020
@rullzer rullzer mentioned this pull request Apr 4, 2020
Merged
80 tasks
rullzer
rullzer approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Apr 8, 2020
Closed
@rullzer rullzer mentioned this pull request Apr 9, 2020
Merged
59 tasks
@blizzz
use serverControls directly with LDAP calls, fixes 19127
84619a5 
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/19127/deprecated-ldap_control_paged_result_1 branch from 265b999 to 84619a5 Compare April 14, 2020 10:58
@blizzz
Copy link
Member Author

blizzz commented Apr 14, 2020

another review? I'd rather have it in earlier than later.

nickvergessen
nickvergessen approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz merged commit 8bc381f into master Apr 15, 2020
@blizzz blizzz deleted the fix/19127/deprecated-ldap_control_paged_result_1 branch April 15, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug enhancement feature: ldap technical debt
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

ldap_control_paged_result() is deprecated spam
3 participants
@blizzz @rullzer @nickvergessen