Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new bootstrap process #2164

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst mentioned this pull request Jun 23, 2020
2 tasks
@ChristophWurst ChristophWurst force-pushed the enhancement/app-dev-bootstrap branch from c44ed8c to 406d7a1 Compare June 23, 2020 13:23
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/app-dev-bootstrap branch from 406d7a1 to 33be7a9 Compare June 23, 2020 13:29

The overall process is as follows.

1) Each installed and enabled app that has an ``Application`` class class that implements ``IBootstrap``, the ``register``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1) Each installed and enabled app that has an ``Application`` class class that implements ``IBootstrap``, the ``register``
1) Each installed and enabled app that has an ``Application`` class that implements ``IBootstrap``, the ``register``

The overall process is as follows.

1) Each installed and enabled app that has an ``Application`` class class that implements ``IBootstrap``, the ``register``
method will be called. This method receives a context argument via which the app can prime the dependency injection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... a context argument to prepare the dependency injection container and register other services lazily.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristophWurst ChristophWurst merged commit ea951bd into master Jun 24, 2020
@ChristophWurst ChristophWurst deleted the enhancement/app-dev-bootstrap branch June 24, 2020 08:34
@marcelklehr
Copy link
Member

Will the old style still be supported?

@ChristophWurst
Copy link
Member Author

Right now, yes. But I guess we will phase out the loading of app.php as it's obsolete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants