Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document unified search API #2166

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 23, 2020

@kesselb
Copy link
Contributor

kesselb commented Jun 23, 2020

cc @marcelklehr @raimund-schluessler does that make sense to you? ;)

@kesselb
Copy link
Contributor

kesselb commented Jun 23, 2020

Also @korelstar for notes ;)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/dev-unified-search branch from 1691bda to e830ceb Compare June 24, 2020 12:40
@marcelklehr
Copy link
Member

LGTM.

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

@ChristophWurst
Copy link
Member Author

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

Most likely, yeah. But the UI part is still to do, so there's a lot that might change. 👀 @skjnldsv @jancborchardt

Ref https://github.com/orgs/nextcloud/projects/38

@ChristophWurst ChristophWurst merged commit fa52171 into master Jun 24, 2020
@ChristophWurst ChristophWurst deleted the enhancement/dev-unified-search branch June 24, 2020 13:38
@jancborchardt
Copy link
Member

Currently, a lot of apps override the default search bar in the menu bar to hook in to their custom search functionality. How do we deal with that? Is that functionality expected to be removed in favor of this new search API?

Yes, so the idea is that the search bar in the header will become the unified search and work the same anywhere.

In-app search would then move into each app, ideally to the top of the AppNavigation to filter content as-you-type. A great example there is Talk, and the same would be possible design-wise for Files, Mail, Contacts, Activity, Bookmarks, Notes, etc. :)

@skjnldsv skjnldsv mentioned this pull request Aug 3, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants