fix: Check before writing if writing without a part file #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
juliusknorr
force-pushed
the
bugfix/noid/s3-upload-block
branch
from
07a978e to
e136955
Compare
|
🏓 @nickvergessen Covered by the integration tests now and ready for review |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/s3-upload-block
branch
from
7ebb78e to
d834286
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/s3-upload-block
branch
from
d834286 to
1c26fea
Compare
nickvergessen
approved these changes
Mar 28, 2023
|
Preparing backports of integration tests so we can also have the stable branches covered. |
|
/backport to stable26 |
1 task
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading to object storage and not using a part file the logic from #170 is behaving badly these days as the unlink will put the file into the trash bin. We can actually check before writing the file to stream as mime types are never detected by content on object storage.
Steps to reproduce:
Before:
See that there is a copy of the file still stored in the trash bin
After:
See that the file is not moved on chunk assembly at all