Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening pdf files in public folder shares #319

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 16, 2021

Adapted version of #309 to make sure that files in public shared folders open again and the original fix of c992b55 is preserved.

We need to handle urls for shares differently since they are not a proper dav path currently

closes #309

@juliusknorr
Copy link
Member Author

/backport to stable21

@juliusknorr
Copy link
Member Author

/backport to stable20

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/public-folder branch from 8b44cb5 to 6efabc8 Compare February 16, 2021 09:33
Copy link
Member

@violoncelloCH violoncelloCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works on NC20

@Vestarija
Copy link

how to apply this fix please?

@nderambure
Copy link

@Vestarija : if you use Nextcloud in production, just wait for the next stable release that may come soon.

@bobpaul
Copy link

bobpaul commented Feb 17, 2021

@Vestarija a sort of ham-fisted "fix" is to just delete the nextcloud/apps/files_pdfviewer folder from the server. Without that folder PDFs will just download when clicked without trying the viewer. When you install NextCloud 20.0.8 it'll re-install the folder.

@skjnldsv
Copy link
Member

@bobpaul you can just disable the app

@Lozrus
Copy link

Lozrus commented Feb 18, 2021

@bobpaul You can also set-up OnlyOffice or the "EPUB/CBZ/PDF ebook reader" app, as alternative PDF viewers. I've settled on OnlyOffice for my servers (which is not a bad viewer at all) while we wait for the fix to filter down.

@Homer-Sim
Copy link

Hello I am on 20.0.9 and his issue is still happening. To deactivate PDF Viewer is not working either. Download is starting but pdf can not be viewer due to corruption issue. File is ok when opening it directly from Server.

Any other options to solve it without waiting for an update?

Thanks

@premar
Copy link

premar commented Apr 26, 2021

Hello, currently running 20.0.9 with same issue. I disabled the plugin but we need the function to view the pdfs.

@premar
Copy link

premar commented Apr 27, 2021

I fixed the problem on our server. It was not related to pdfviewer app but the server itself. We using external storage, and its broken in the new 20.0.9 version and 21. See this Issue nextcloud/server#26457. I used the fix from https://blog.nuvotex.de/nextcloud-smb-stringbuffer/ to resolve the problem.

@Homer-Sim
Copy link

I fixed the problem on our server. It was not related to pdfviewer app but the server itself. We using external storage, and its broken in the new 20.0.9 version and 21. See this Issue nextcloud/server#26457. I used the fix from https://blog.nuvotex.de/nextcloud-smb-stringbuffer/ to resolve the problem.

Thats IT!!!!!!!!!! GREAT !!!!

@supr4s
Copy link

supr4s commented May 18, 2021

Well, on some servers that have been upgraded, problem still exists despite the application of the patch seen here: https://blog.nuvotex.de/nextcloud-smb-stringbuffer/

For this server, users have their mount volumes via an SMB share.

Upgrade from Nextcloud 19.0.4 to 20.9 => non-functional. Implementation of the patch => problem still present.

Upgrade to 20.9 green 21.0.1 => still the same.

In addition, another problem: when a user downloads from the web interface a .docsx, .xlsx etc and opens it on his computer => corrupted/damaged file, impossible to recover. And for all downloaded files!

I had to go back via a snapshot of the server to return to version 19.0.4 which had no problem, and which allows users to work correctly.

I will try again in a few weeks depending on the progress of the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants