Fix hinting to public class #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
nickvergessen
requested changes
Apr 10, 2017
| @@ -63,7 +64,8 @@ public function disable() { | |||
| * @return TemplateResponse | |||
| */ | |||
| public function show() { | |||
| $theming = \OC::$server->getThemingDefaults(); | |||
| /** @var Defaults $theming */ | |||
| $theming = \OC::$server->query(Defaults::class); | |||
There was a problem hiding this comment.
I don't really get why we need to change this. I would like to avoid this. Because it basically means the API changed....
There was a problem hiding this comment.
No it does not. Because getThemingDefaults was never in OCP 😉
There was a problem hiding this comment.
This is basically only using the proper public interface instead of a private one from an app. (either returned OCA\Theming\ThemingDefaults or OC_Defaults).
LukasReschke
approved these changes
Aug 8, 2017
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.