-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI polishing #71
UI polishing #71
Conversation
@jancborchardt I cannot see any missing icon there, can you point me to what exactly is missing
@jancborchardt Do you have that image at hand somewhere? Or maybe @jospoortvliet And should this image replace the header area with the background image or the content, where we have the core values? Because then we would need to move the core values to a separate page. |
@juliushaertl sent you the link to the background image via Nextcloud Talk. ;) I can actually not reproduce the icons not loading, maybe another problem specific to Franks setup. But I found 2 new issues:
|
And the image should replace the icons / text boxes on the bottom. And if I remember correctly (correct me if I’m wrong @jospoortvliet) we decided that we do not insert another slide for it, because it’s just too much blabla that people will skip anyhow. |
@jancborchardt The icons about the core values of Nextcloud were actually the main requirement for the firstrunwizard rework. See #57 so I wonder why those are supposed to be dropped again. Also just using the image instead of the text/icons as a first slide doesn't provide any value to the user: But I like the idea of using that image, maybe as the header image: |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
bac9300
to
338a90a
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl Should we get this in like it is now and finish the polishing later? |
@MorrisJobke Good to go from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
<?php p($l->t('Connect your calendar'));?> | ||
</a> | ||
<a target="_blank" class="button" href="<?php p(link_to_docs('user-sync-contacts')) ?>"> | ||
<img class="appsmall appsmall-contacts svg" alt="" | ||
src="<?php p(image_path('core', 'places/contacts-dark.svg')); ?>" /> | ||
src="<?php p(image_path('core', 'places/contacts.svg')); ?>" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl I fixed the icons in here as well 😉
From nextcloud/server#10094
Icons on some entries missing