Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review / polishing items for Nextcloud 14 (overview issue) #10094

Closed
24 of 31 tasks
jancborchardt opened this issue Jul 3, 2018 · 16 comments
Closed
24 of 31 tasks
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. overview papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jul 3, 2018

Had a design review session of latest master with @karlitschek today, here are the results:

General

  • Font is not loading? Testing on Frank's laptop, only Helvetica showed, not Open Sans

First run wizard

Files

App management

User management

Settings

Still to discuss

  • Add nice header images for Settings sections of more obscure features like federated sharing, File access control, Workflow, Groupware, etc. Basically like on the website https://nextcloud.com/workflow with image, heading and subtitle
  • Sharing: More padding for checkbox entries, 44px as usual
  • Federated cloud: Could use a nice graphic? Also we should add more explanatory text from https://nextcloud.com/federation
  • Padding for checkbox settings (bottom left Files settings, Files sidebar link share options, Sharing settings): every entry needs at least 44px height for clickability, and more whitespace between checkbox and text
@jancborchardt jancborchardt added this to the Nextcloud 14 milestone Jul 3, 2018
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. bug labels Jul 3, 2018
@jancborchardt
Copy link
Member Author

cc @nextcloud/designers @nextcloud/javascript lots of small tasks to pick up in there also. Good for getting friends involved too. :)

rullzer added a commit that referenced this issue Jul 4, 2018
For #10094

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@nextcloud nextcloud deleted a comment from nextcloud-bot Jul 4, 2018
@Bournout3000

This comment has been minimized.

@ykcab

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@ykcab

This comment has been minimized.

@juliushaertl
Copy link
Member

juliushaertl commented Jul 17, 2018

 Font is not loading? Testing on Frank's laptop, only Helvetica showed, not Open Sans

Move or copy buttons in dialog stacked on top, should be side by side

I cannot reproduce those. What browser did you use when testing?

 Padding for checkbox settings (bottom left Files settings, Files sidebar link share options, Sharing settings): every entry needs at least 44px height for clickability, and more whitespace between checkbox and text

Increasing the padding here will make the whole layout look a bit out of place in my opinion:

image

@jancborchardt Having 44px height makes sense for the share options and the first checkbox to toggle the link share, but I would keep the small height for the link share options. I think an increased click target to 44px doesn't work well here, since you cannot clearly separate between the two lines.

@jancborchardt
Copy link
Member Author

Increasing the padding here will make the whole layout look a bit out of place in my opinion:

Right, also true. We should really put all these things in a proper popover like started in #7010, but I need help with that. ;)
And then we will also have a proper whitespace between radio/checkbox and the text.

 Font is not loading? Testing on Frank's laptop, only Helvetica showed, not Open Sans

Move or copy buttons in dialog stacked on top, should be side by side

I cannot reproduce those. What browser did you use when testing?

Yes, the font issue I can not reproduce either, and others couldn’t either? Might be specific to @karlitschek’s setup?

The move or copy buttons seem to only be broken in Safari, just tested with @MorrisJobke

@karlitschek
Copy link
Member

@jancborchardt @MorrisJobke @juliushaertl possible that the font loading issue is triggered by my ad blocker or something else. I will investigate.

@MariusBluem
Copy link
Member

bildschirmfoto 2018-07-24 um 12 11 58

  • Adding icons as done in Talk (or is it only a bug that they are not shown)

@MorrisJobke
Copy link
Member

Adding icons as done in Talk (or is it only a bug that they are not shown)

There are none - planned in the sidebar overview ticket: #10289

@juliushaertl
Copy link
Member

Federated cloud: Could use a nice graphic? Also we should add more explanatory text from https://nextcloud.com/federation

@jancborchardt Do you have any specific graphic in mind for that?

@juliushaertl
Copy link
Member

Add nice header images for Settings sections of more obscure features like federated sharing, File access control, Workflow, Groupware, etc. Basically like on the website nextcloud.com/workflow with image, heading and subtitle

@jancborchardt I don't like adding big images to the UI. I think they add to much visual distraction from the settings and don't provide any value regarding the content. We should keep it simple there and focus on providing a simple description and a link to possible extended documentation there.

cc @nextcloud/designers

@juliushaertl
Copy link
Member

Padding for checkbox settings (bottom left Files settings, Files sidebar link share options, Sharing settings): every entry needs at least 44px height for clickability, and more whitespace between checkbox and text

We could add a padding to all checkboxes with their labels in the global input css, but I would suggest to do this for 15, since i would expect this might cause quite some bugs all over the places where the checkboxes are used.

@rullzer rullzer mentioned this issue Aug 2, 2018
58 tasks
@ykcab
Copy link

ykcab commented Aug 4, 2018

Hi team,
I was curious if there is a work around on this issue "Content-Security-Policy" with CloudFlare. I just installed the beta version and this issue persists on 14 beta.

@rullzer
Copy link
Member

rullzer commented Aug 6, 2018

@ykcab please open an issue for this so we can discuss it

@juliushaertl
Copy link
Member

Should be all fixed now, besides those I moved to separate issues for further discussion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. overview papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

9 participants