Settings UI enhancements #1094
Merged
Settings UI enhancements #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliushaertl
commented
Aug 1, 2018
•
juliushaertl
commented
- Move shared secret description above the input field to avoid space between from Design review / polishing items for Nextcloud 14 (overview issue) server#10094
- Increase add/delete button size and align them properly to the input fields
- Add aria-label values to the input fields
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Ivansss
approved these changes
Aug 1, 2018
nickvergessen
previously requested changes
Aug 1, 2018
| <p class="hidden"> | ||
| <label for="signaling_secret"><?php p($l->t('Shared secret')) ?></label> | ||
| <div class="signaling-secret"> | ||
| <h4>Shared secret</h4> |
There was a problem hiding this comment.
This is not translated anymore?!
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
settings-ui-enhancements
branch
from
6741e56
to
9a31627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.