-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move actions of sharing link to popover menu #7010
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
I would say we should better spend our time on #5336 and then this will be automatically be the case. Otherwise there was no activity since over half a year. Let's close it then and we can reopen anytime once this turns out to be the way to go. |
@MorrisJobke this is actually intended to be a first step towards implementation of #5336, and it’s still the way to go. I wouldn’t close it hence, but it would be nice if some @nextcloud/javascript folks could have a look at it. :) |
Codecov Report
@@ Coverage Diff @@
## master #7010 +/- ##
============================================
- Coverage 52.76% 52.52% -0.25%
Complexity 22802 22802
============================================
Files 1442 1381 -61
Lines 88563 80950 -7613
Branches 1349 0 -1349
============================================
- Hits 46729 42517 -4212
+ Misses 41834 38433 -3401 |
This is now the case: Was fixed by #10218 |
Moving the actions (editability, password protection) to the 3-dot-menu which is shown to the right of the share link input.
TODO and where I need help from @nextcloud/javascript @blizzz @MorrisJobke @danxuliu