This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Public page response #425
Merged
Public page response #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
added
design
danxuliu
previously requested changes
Apr 5, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
Tests are fixed, they still fail because the new classes from nextcloud/server#9084 are not available. Once that is merged they should run fine. |
Retriggered them, because server PR was merged. |
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
============================================
+ Coverage 82.55% 82.61% +0.05%
Complexity 360 360
============================================
Files 38 38
Lines 1313 1323 +10
============================================
+ Hits 1084 1093 +9
- Misses 229 230 +1
Continue to review full report at Codecov.
|
|
Look at all this beautiful green :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new PublicPageResponse for NC14+ to render public pages that have the same header actions as the files_sharing app.
Fixes #403 and #358
Requires nextcloud/server#9084