Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public page template enhancements #9084

Merged
merged 9 commits into from
Apr 6, 2018
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 5, 2018

  • Move common menu templates from the files_sharing app to public API
  • Add footer to all public pages
  • Some cleanup of public page styles (moving them out of the files_sharing app)

required for nextcloud/gallery#425

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added the 2. developing Work in progress label Apr 5, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #9084 into master will decrease coverage by 0.07%.
The diff coverage is 22.58%.

@@             Coverage Diff              @@
##             master    #9084      +/-   ##
============================================
- Coverage     51.96%   51.89%   -0.08%     
- Complexity    25287    25289       +2     
============================================
  Files          1601     1601              
  Lines         94978    94981       +3     
  Branches       1388     1388              
============================================
- Hits          49360    49294      -66     
- Misses        45618    45687      +69
Impacted Files Coverage Δ Complexity Δ
...es_sharing/composer/composer/autoload_classmap.php 0% <ø> (ø) 0 <0> (ø) ⬇️
...blic/AppFramework/Http/Template/LinkMenuAction.php 14.28% <ø> (ø) 2 <0> (?)
...iles_sharing/composer/composer/autoload_static.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...s/files_sharing/lib/Controller/ShareController.php 47.38% <ø> (ø) 64 <0> (ø) ⬇️
apps/files_sharing/templates/public.php 0% <0%> (ø) 0 <0> (ø) ⬇️
core/templates/layout.public.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...Framework/Http/Template/PublicTemplateResponse.php 67.56% <0%> (-8.2%) 16 <2> (+2)
...ramework/Http/Template/ExternalShareMenuAction.php 31.25% <0%> (ø) 2 <0> (?)
apps/files_sharing/js/public.js 47.91% <0%> (-0.83%) 0 <0> (ø)
core/js/public/publicpage.js 66.66% <70%> (-8.34%) 0 <0> (ø)
... and 5 more

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the public-page-template-extend branch from a168837 to 50a763e Compare April 5, 2018 12:27
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 2a2ab1b into master Apr 6, 2018
@MorrisJobke MorrisJobke deleted the public-page-template-extend branch April 6, 2018 11:16
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants