Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to server API changes #2447

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Adapt to server API changes #2447

merged 4 commits into from
Jun 29, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 28, 2023

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title bugfix/noid/adapt server Adapt to server API changes Jun 28, 2023
@juliusknorr juliusknorr added bug 3. to review Items that need to be reviewed labels Jun 28, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
@kesselb
Copy link
Contributor

kesselb commented Jun 28, 2023

PHP Fatal error: Class OCA\GroupFolders\Helper\LazyFolder contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Files\Folder::searchBySystemTag) in /var/www/html/apps-extra/groupfolders/lib/Helper/LazyFolder.php on line 32

Thanks 👍

occ upgrade greeted me with the above error today. It works fine with your patch applied.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@juliusknorr juliusknorr merged commit 1888cff into master Jun 29, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/adapt-server branch June 29, 2023 08:07
@juliusknorr
Copy link
Member Author

/backport 42fb12b,98eded8,9130130 to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@AndyScherzinger
Copy link
Member

Did this now get manually backported? @juliushaertl

@ChristophWurst
Copy link
Member

/backport 42fb12ba06cc4b45d0afdac2f92433b1d246e8b0,98eded8,9130130 to stable27

@ChristophWurst
Copy link
Member

/backport 42fb12b,98eded8,9130130 to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@AndyScherzinger
Copy link
Member

@ChristophWurst seems like the backport bot isn't willing to help us out with this one 😕

@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 10, 2023

Seems to have found its way to the stable27 branch already with #2423

bc67e18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants