repair -1 folder sizes for object store background scan #37691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
come-nc,
a team,
ArtificialOwl and
blizzz
and removed request for
a team
come-nc
reviewed
Apr 17, 2023
icewind1991
force-pushed
the
object-store-background-scan
branch
from
8a4e275 to
d101999
Compare
come-nc
approved these changes
May 2, 2023
Merged
blizzz
reviewed
May 3, 2023
Comment on lines
+92
to
+64
| // FIXME: this won't proceed with the next item, needs revamping of getIncomplete() | ||
| // to make this possible |
There was a problem hiding this comment.
eventually™.
it would require some deeper rework of how unscanned files are detected which I wouldn't want to do here
icewind1991
force-pushed
the
object-store-background-scan
branch
from
d101999 to
b1327f1
Compare
skjnldsv
approved these changes
May 9, 2023
skjnldsv
added
4. to release
icewind1991
force-pushed
the
object-store-background-scan
branch
from
b1327f1 to
ff8feca
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
object-store-background-scan
branch
from
ff8feca to
2ea41da
Compare
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the object store background scan from a noop to repairing -1 sizes properly.