-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Emitter event so that other apps know about impersonate #179
Comments
should be a typed event nowadays, but generally a PR implemeted this would be accepted. As a workaround, perhaps checking whether |
That has an issue.
Step 5 - 6 will then be a repeat, so there must be some kind of permanent check.
|
WIP at #180 |
My app has a login system and users have an issue when impersonating, the login doesn't logout.
the-djmaze/snappymail#561
I've tried to create a workaround but that has issues with storing data in session (NC25 might solve this).
nextcloud/server#34935
However, i think it would be better to have an event to listen to for a much better approach.
Can you add an emit() like:
impersonate/lib/Controller/SettingsController.php
Line 157 in 7690e01
impersonate/lib/Controller/LogoutController.php
Line 63 in 7690e01
The text was updated successfully, but these errors were encountered: