Add ImpersonateEvents for SnappyMail (and others) #180
Conversation
|
Does it carry enough information to know which user is impersonated, and when impersonation finishes? It looks like to do guess work. What about having |
For me personally i don't care which user. Just "impersonate" is enough for me to force logout. I've just extended it a bit if other apps also want to use it. Just do what you think is right. |
|
@the-djmaze added a commit, does this work for you? I removed the legacy emitter, it should not be used anymore. It carries only some legacy bits (which should be phased out…) |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
ImpersonateEvent
branch
from
5028964 to
cc35951
Compare
blizzz
changed the title
|
@the-djmaze does it work for you? ^ |
|
I will check! |
blizzz
requested review from
nickvergessen,
come-nc,
a team,
icewind1991 and
CarlSchwan
and removed request for
a team
lib/Controller/LogoutController.php
Outdated
| $user = $this->session->get('oldUserId'); | ||
| $user = $this->userManager->get($user); | ||
| $impersonator = $this->session->get('oldUserId'); | ||
| $impersonator = $this->userManager->get($impersonator); |
There was a problem hiding this comment.
Would recommend different variable names for the uid and the user object
There was a problem hiding this comment.
Had the same feeling and almost changed it back then. Well, almost. 👍
lib/Controller/LogoutController.php
Outdated
| @@ -60,7 +66,10 @@ public function logout(string $userId): JSONResponse { | |||
| ); | |||
| } | |||
|
|
|||
| $this->userSession->setUser($user); | |||
| $impersonatee = $this->userManager->get($userId); | |||
There was a problem hiding this comment.
I love the more clearer distinction on the name of the Getter function on the event.
...tee vs ...tor is visually so similar. $impersonatedUser would be more different.
There was a problem hiding this comment.
Ah, actually as i did in the Event class… =D
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
On logout i get: Further it works as expected and helps a lot! |
I'll have another look, thanks for spotting it! |
Probably needs adjustements on the impersonate_logout.js code, perhaps getting rid of jquery traces 🙈 needs more looking into |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
Latest commit fixes logout |
|
/backport to stable25 |
More info at #179